| Summary: | [JSC] Reduce Baseline JIT code size in debug builds | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Geza Lore <glore> | ||||||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Geza Lore
2022-04-07 06:05:38 PDT
Created attachment 456917 [details]
Patch
Created attachment 456940 [details]
Patch
Comment on attachment 456940 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456940&action=review > Source/JavaScriptCore/jit/JIT.cpp:682 > +#if CPU(X86_64) > + jit.subPtr(TrustedImm32(sizeof(void*)), expectedStackPointerGPR); // Call instruction pushed to stack > +#endif You can use prologueStackPointerDelta() and sizeof(CallerFrameAndPC) to compute it for all architectures. Created attachment 457240 [details]
Patch
(In reply to Yusuke Suzuki from comment #3) > Comment on attachment 456940 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=456940&action=review > > > Source/JavaScriptCore/jit/JIT.cpp:682 > > +#if CPU(X86_64) > > + jit.subPtr(TrustedImm32(sizeof(void*)), expectedStackPointerGPR); // Call instruction pushed to stack > > +#endif > > You can use prologueStackPointerDelta() and sizeof(CallerFrameAndPC) to > compute it for all architectures. Neat, thanks. r? Created attachment 457245 [details]
Patch
Comment on attachment 457245 [details]
Patch
r=me
Committed r292767 (249551@main): <https://commits.webkit.org/249551@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457245 [details]. |