Bug 238920

Summary:

REGRESSION(r291509): imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage-video.html is a constant text failure

Product:

WebKit

Reporter:

Dawn Morningstar <Morningstar>

Component:

New Bugs

Assignee:

Dawn Morningstar <Morningstar>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

clopez, eric.carlson, ews-watchlist, glenn, heycam, jer.noble, philipj, sergio, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=237286

Attachments:

Description	Flags
Patch	none

Description Dawn Morningstar 2022-04-06 20:03:47 PDT

imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage-video.html
is a constant text failure on Monterey

This failure appears to be due to a typo in r291509 line 16:
                    let testVidoe = t.step_func_done(function() {


HISTORY:
https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fcanvas%2Felement%2Fmanual%2Fwide-gamut-canvas%2Fcanvas-display-p3-drawImage-video.html

DIFF:
--- /Volumes/Data/worker/monterey-release-applesilicon-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage-video-expected.txt
+++ /Volumes/Data/worker/monterey-release-applesilicon-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage-video-actual.txt
@@ -1,34 +1,34 @@
 
-PASS sRGB-FF0100, Context srgb, ImageData srgb, scaleImage=false
-PASS sRGB-FF0100, Context srgb, ImageData srgb, scaleImage=true
-PASS sRGB-FF0100, Context srgb, ImageData display-p3, scaleImage=false
-PASS sRGB-FF0100, Context srgb, ImageData display-p3, scaleImage=true
-PASS sRGB-FF0100, Context display-p3, ImageData srgb, scaleImage=false
-PASS sRGB-FF0100, Context display-p3, ImageData srgb, scaleImage=true
-PASS sRGB-FF0100, Context display-p3, ImageData display-p3, scaleImage=false
-PASS sRGB-FF0100, Context display-p3, ImageData display-p3, scaleImage=true
-PASS sRGB-BB0000, Context srgb, ImageData srgb, scaleImage=false
-PASS sRGB-BB0000, Context srgb, ImageData srgb, scaleImage=true
-PASS sRGB-BB0000, Context srgb, ImageData display-p3, scaleImage=false
-PASS sRGB-BB0000, Context srgb, ImageData display-p3, scaleImage=true
-PASS sRGB-BB0000, Context display-p3, ImageData srgb, scaleImage=false
-PASS sRGB-BB0000, Context display-p3, ImageData srgb, scaleImage=true
-PASS sRGB-BB0000, Context display-p3, ImageData display-p3, scaleImage=false
-PASS sRGB-BB0000, Context display-p3, ImageData display-p3, scaleImage=true
-PASS Rec2020-3FF000000, Context srgb, ImageData srgb, scaleImage=false
-PASS Rec2020-3FF000000, Context srgb, ImageData srgb, scaleImage=true
-PASS Rec2020-3FF000000, Context srgb, ImageData display-p3, scaleImage=false
-PASS Rec2020-3FF000000, Context srgb, ImageData display-p3, scaleImage=true
-PASS Rec2020-3FF000000, Context display-p3, ImageData srgb, scaleImage=false
-PASS Rec2020-3FF000000, Context display-p3, ImageData srgb, scaleImage=true
-PASS Rec2020-3FF000000, Context display-p3, ImageData display-p3, scaleImage=false
-PASS Rec2020-3FF000000, Context display-p3, ImageData display-p3, scaleImage=true
-PASS Rec2020-222000000, Context srgb, ImageData srgb, scaleImage=false
-PASS Rec2020-222000000, Context srgb, ImageData srgb, scaleImage=true
-PASS Rec2020-222000000, Context srgb, ImageData display-p3, scaleImage=false
-PASS Rec2020-222000000, Context srgb, ImageData display-p3, scaleImage=true
-PASS Rec2020-222000000, Context display-p3, ImageData srgb, scaleImage=false
-PASS Rec2020-222000000, Context display-p3, ImageData srgb, scaleImage=true
-PASS Rec2020-222000000, Context display-p3, ImageData display-p3, scaleImage=false
-PASS Rec2020-222000000, Context display-p3, ImageData display-p3, scaleImage=true
+FAIL sRGB-FF0100, Context srgb, ImageData srgb, scaleImage=false Can't find variable: testVideo
+FAIL sRGB-FF0100, Context srgb, ImageData srgb, scaleImage=true Can't find variable: testVideo
+FAIL sRGB-FF0100, Context srgb, ImageData display-p3, scaleImage=false Can't find variable: testVideo
+FAIL sRGB-FF0100, Context srgb, ImageData display-p3, scaleImage=true Can't find variable: testVideo
+FAIL sRGB-FF0100, Context display-p3, ImageData srgb, scaleImage=false Can't find variable: testVideo
+FAIL sRGB-FF0100, Context display-p3, ImageData srgb, scaleImage=true Can't find variable: testVideo
+FAIL sRGB-FF0100, Context display-p3, ImageData display-p3, scaleImage=false Can't find variable: testVideo
+FAIL sRGB-FF0100, Context display-p3, ImageData display-p3, scaleImage=true Can't find variable: testVideo
+FAIL sRGB-BB0000, Context srgb, ImageData srgb, scaleImage=false Can't find variable: testVideo
+FAIL sRGB-BB0000, Context srgb, ImageData srgb, scaleImage=true Can't find variable: testVideo
+FAIL sRGB-BB0000, Context srgb, ImageData display-p3, scaleImage=false Can't find variable: testVideo
+FAIL sRGB-BB0000, Context srgb, ImageData display-p3, scaleImage=true Can't find variable: testVideo
+FAIL sRGB-BB0000, Context display-p3, ImageData srgb, scaleImage=false Can't find variable: testVideo
+FAIL sRGB-BB0000, Context display-p3, ImageData srgb, scaleImage=true Can't find variable: testVideo
+FAIL sRGB-BB0000, Context display-p3, ImageData display-p3, scaleImage=false Can't find variable: testVideo
+FAIL sRGB-BB0000, Context display-p3, ImageData display-p3, scaleImage=true Can't find variable: testVideo
+FAIL Rec2020-3FF000000, Context srgb, ImageData srgb, scaleImage=false Can't find variable: testVideo
+FAIL Rec2020-3FF000000, Context srgb, ImageData srgb, scaleImage=true Can't find variable: testVideo
+FAIL Rec2020-3FF000000, Context srgb, ImageData display-p3, scaleImage=false Can't find variable: testVideo
+FAIL Rec2020-3FF000000, Context srgb, ImageData display-p3, scaleImage=true Can't find variable: testVideo
+FAIL Rec2020-3FF000000, Context display-p3, ImageData srgb, scaleImage=false Can't find variable: testVideo
+FAIL Rec2020-3FF000000, Context display-p3, ImageData srgb, scaleImage=true Can't find variable: testVideo
+FAIL Rec2020-3FF000000, Context display-p3, ImageData display-p3, scaleImage=false Can't find variable: testVideo
+FAIL Rec2020-3FF000000, Context display-p3, ImageData display-p3, scaleImage=true Can't find variable: testVideo
+FAIL Rec2020-222000000, Context srgb, ImageData srgb, scaleImage=false Can't find variable: testVideo
+FAIL Rec2020-222000000, Context srgb, ImageData srgb, scaleImage=true Can't find variable: testVideo
+FAIL Rec2020-222000000, Context srgb, ImageData display-p3, scaleImage=false Can't find variable: testVideo
+FAIL Rec2020-222000000, Context srgb, ImageData display-p3, scaleImage=true Can't find variable: testVideo
+FAIL Rec2020-222000000, Context display-p3, ImageData srgb, scaleImage=false Can't find variable: testVideo
+FAIL Rec2020-222000000, Context display-p3, ImageData srgb, scaleImage=true Can't find variable: testVideo
+FAIL Rec2020-222000000, Context display-p3, ImageData display-p3, scaleImage=false Can't find variable: testVideo
+FAIL Rec2020-222000000, Context display-p3, ImageData display-p3, scaleImage=true Can't find variable: testVideo

DIFF-URL:
https://build.webkit.org/results/Apple-Monterey-Release-AppleSilicon-WK2-Tests/r291517%20(2287)/imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage-video-diff.txt

Comment 1 Radar WebKit Bug Importer 2022-04-06 20:04:15 PDT

<rdar://problem/91390619>

Comment 2 Dawn Morningstar 2022-04-06 20:26:18 PDT

Pull request: https://github.com/WebKit/WebKit/pull/256

Comment 3 Dawn Morningstar 2022-04-06 20:39:58 PDT

Created attachment 456886 [details]
Patch

Comment 4 EWS Watchlist 2022-04-06 20:41:45 PDT

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

Comment 5 Dawn Morningstar 2022-04-06 20:46:09 PDT

(In reply to Matteo Flores from comment #2)
> Pull request: https://github.com/WebKit/WebKit/pull/256

- Ignore this I was using a new-workflow command, changed to webkit-patch as per website documentation.

Comment 6 Dawn Morningstar 2022-04-07 15:03:00 PDT

Comment on attachment 456886 [details]
Patch

cq+

Comment 7 EWS 2022-04-07 15:35:49 PDT

Committed r292570 (249408@main): <https://commits.webkit.org/249408@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456886 [details].