Bug 238912

Summary: Adjust and refactor some UA styles and logic for injecting Live Text
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: PlatformAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: akeerthi, cdumez, changseok, esprehn+autocc, ews-watchlist, gyuyoung.kim, hi, kangil.han, katherine_cheney, megan_gardner, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
akeerthi: review+, ews-feeder: commit-queue-
Patch for landing none

Description Wenson Hsieh 2022-04-06 16:58:51 PDT 
rdar://91383570
Comment 1 Wenson Hsieh 2022-04-06 18:01:25 PDT 
Created attachment 456879 [details]
Patch
Comment 2 Aditya Keerthi 2022-04-06 20:30:19 PDT 
Comment on attachment 456879 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456879&action=review

> Source/WebCore/dom/ImageOverlay.cpp:445
> +            if (lines.size() > 2)

Nit: Named constant?
Comment 3 Wenson Hsieh 2022-04-07 07:52:36 PDT 
Comment on attachment 456879 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456879&action=review

Thanks for the review!

>> Source/WebCore/dom/ImageOverlay.cpp:445
>> +            if (lines.size() > 2)
> 
> Nit: Named constant?

Makes sense — I'll change this to use `constexpr auto maxLineCountForCenterAlignedText = 2;`
Comment 4 Wenson Hsieh 2022-04-07 07:53:55 PDT 
Created attachment 456924 [details]
Patch for landing
Comment 5 EWS 2022-04-07 10:23:21 PDT 
Committed r292543 (249381@main): <https://commits.webkit.org/249381@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456924 [details].