Bug 238876

Summary: Drop unnecessary ExceptionOr<> return types
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cgarcia, changseok, cmarcelo, darin, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, gyuyoung.kim, hi, jer.noble, joepeck, kangil.han, macpherson, menard, pangle, philipj, rniwa, sam, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ews-feeder: commit-queue-

Description Chris Dumez 2022-04-06 10:36:05 PDT 
Drop unnecessary ExceptionOr<> return types as they may cause unnecessary branching at runtime.
Comment 1 Chris Dumez 2022-04-06 10:37:19 PDT 
Created attachment 456832 [details]
Patch
Comment 2 Alex Christensen 2022-04-06 11:53:06 PDT 
Comment on attachment 456832 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456832&action=review

> Source/WebCore/html/CustomPaintCanvas.cpp:59
>          return { RefPtr<PaintRenderingContext2D> { &downcast<PaintRenderingContext2D>(*m_context) } };

This can be cleaned up too
Comment 3 Chris Dumez 2022-04-06 12:02:44 PDT 
Created attachment 456845 [details]
Patch
Comment 4 EWS 2022-04-06 14:30:13 PDT 
Committed r292506 (249349@main): <https://commits.webkit.org/249349@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456845 [details].
Comment 5 Radar WebKit Bug Importer 2022-04-06 14:31:16 PDT 
<rdar://problem/91376356>
Comment 6 Carlos Garcia Campos 2022-04-07 03:58:46 PDT 
This broke the GTK build, as the EWS caught. Fixed in r292529.
Comment 7 Chris Dumez 2022-04-07 07:21:48 PDT 
(In reply to Carlos Garcia Campos from comment #6)
> This broke the GTK build, as the EWS caught. Fixed in r292529.

Thanks for fixing. I guess gtk-ews was slow at the time.