| Summary: | Remove some @apply leftover code | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||
| Component: | CSS | Assignee: | Antti Koivisto <koivisto> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, ntim, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Antti Koivisto
2022-04-06 01:15:37 PDT
Created attachment 456789 [details]
Patch
Comment on attachment 456789 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456789&action=review > Source/WebCore/css/parser/CSSVariableParser.cpp:91 > + case AtKeywordToken: > break; Is it possible to delete this? `default:` bellow seems to handle it. > Is it possible to delete this? `default:` bellow seems to handle it.
A better direction might be to eliminate the default branch. Then everyone who adds a new token type needs to consider this code too.
Committed r292455 (249306@main): <https://commits.webkit.org/249306@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456789 [details]. |