| Summary: | Call Structure::get instead of Structure::getConcurrently on the mutator thread | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> | ||||||
| Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, tzagallo, webkit-bug-importer, ysuzuki | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Saam Barati
2022-04-05 11:33:08 PDT
Created attachment 456774 [details]
patch
Comment on attachment 456774 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=456774&action=review r=me > Source/JavaScriptCore/runtime/JSObject.h:1418 > + case Concurrency::MainThread: Let's add `ASSERT(!isCompilationThread() && !Thread::mayBeGCThread());` assertion. > Source/JavaScriptCore/runtime/Structure.h:520 > + case Concurrency::MainThread: Let's add `ASSERT(!isCompilationThread() && !Thread::mayBeGCThread());` assertion. > Source/JavaScriptCore/runtime/Structure.h:530 > + case Concurrency::MainThread: Let's add `ASSERT(!isCompilationThread() && !Thread::mayBeGCThread());` assertion. Created attachment 456839 [details]
patch for landing
Committed r292493 (249341@main): <https://commits.webkit.org/249341@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456839 [details]. |