Bug 238821

Summary:

[Refactor] Introduce a SeekCompletion callback for MediaPlayer seek commands

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

New Bugs

Assignee:

Jer Noble <jer.noble>

Status:

NEW ---

Severity:

Normal

CC:

calvaris, cdumez, changseok, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jean-yves.avenard, philipj, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	eric.carlson: review+, ews-feeder: commit-queue-

Description Jer Noble 2022-04-05 10:51:07 PDT

[Refactor] Introduce a SeekCompletion callback for MediaPlayer seek commands

Comment 1 Jer Noble 2022-04-05 10:55:11 PDT

Created attachment 456723 [details]
Patch

Comment 2 Radar WebKit Bug Importer 2022-04-12 10:52:15 PDT

<rdar://problem/91637043>

Comment 3 Eric Carlson 2022-04-13 08:43:04 PDT

Comment on attachment 456723 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456723&action=review

> Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:298
> +        ALWAYS_LOG(identifier, "::completion(), result = ", result);
> +
> +        m_seeking = false;

Shouldn't we do a `weakThis` null-test here?

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:582
> +        (*m_seekCompletion)(MediaPlayerEnums::SeekResult::Completed);
> +        m_seekCompletion = nullptr;

Maybe clear `m_seekCompletion` before calling the completion handler in case it results in a call back into the player?

Comment 4 Jer Noble 2022-05-20 20:46:27 PDT

Pull request: https://github.com/WebKit/WebKit/pull/876