Bug 238821

Summary: [Refactor] Introduce a SeekCompletion callback for MediaPlayer seek commands
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: NEW    
Severity: Normal CC: calvaris, cdumez, changseok, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jean-yves.avenard, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch eric.carlson: review+, ews-feeder: commit-queue-

Jer Noble
Reported 2022-04-05 10:51:07 PDT
[Refactor] Introduce a SeekCompletion callback for MediaPlayer seek commands
Attachments
Patch (30.80 KB, patch)
2022-04-05 10:55 PDT, Jer Noble 		eric.carlson: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2022-04-05 10:55:11 PDT
Created attachment 456723 [details] Patch
Radar WebKit Bug Importer
Comment 2 2022-04-12 10:52:15 PDT
<rdar://problem/91637043>
Eric Carlson
Comment 3 2022-04-13 08:43:04 PDT
Comment on attachment 456723 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456723&action=review > Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:298 > + ALWAYS_LOG(identifier, "::completion(), result = ", result); > + > + m_seeking = false; Shouldn't we do a `weakThis` null-test here? > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:582 > + (*m_seekCompletion)(MediaPlayerEnums::SeekResult::Completed); > + m_seekCompletion = nullptr; Maybe clear `m_seekCompletion` before calling the completion handler in case it results in a call back into the player?
Jer Noble
Comment 4 2022-05-20 20:46:27 PDT
Pull request: https://github.com/WebKit/WebKit/pull/876
Note You need to log in before you can comment on or make changes to this bug.