| Summary: | Implement faster lookup of HTML tags in the HTML parser | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
| Component: | DOM | Assignee: | Chris Dumez <cdumez> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | changseok, darin, esprehn+autocc, ews-watchlist, ggaren, gyuyoung.kim, heycam, kangil.han, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Chris Dumez
2022-04-05 07:49:05 PDT
Created attachment 456699 [details]
Patch
Created attachment 456700 [details]
Generated findHTMLTag() function to facilitate review
Created attachment 456708 [details]
Patch
Comment on attachment 456708 [details]
Patch
r=me
Something I said in Slack to Chris: We might get more efficient branching if we eliminate the initial switch on length (since it does not eliminate many possibilities) and/or reorder the branches to make more likely tags like "div" fewer branches.
(In reply to Geoffrey Garen from comment #4) > Comment on attachment 456708 [details] > Patch > > r=me > > Something I said in Slack to Chris: We might get more efficient branching if > we eliminate the initial switch on length (since it does not eliminate many > possibilities) and/or reorder the branches to make more likely tags like > "div" fewer branches. Yes, I will look into this and follow-up if A/B testing comes back as a further progression. Committed r292417 (249280@main): <https://commits.webkit.org/249280@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456708 [details]. |