Bug 238803

Summary: [Forms] Use button instead of push-button appearance for input[type=submit|reset|button]
Product: WebKit Reporter: Tim Nguyen (:ntim) <ntim>
Component: CSSAssignee: Tim Nguyen (:ntim) <ntim>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, esprehn+autocc, ews-watchlist, glenn, jasneet, karlcow, kondapallykalyan, MatsPalmgren_bugz, pdr, vanita.barrett, webkit-bug-importer
Priority: P2 Keywords: BrowserCompat, InRadar, WPTImpact
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=224746
Bug Depends on:    
Bug Blocks: 245355    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch ews-feeder: commit-queue-

Description Tim Nguyen (:ntim) 2022-04-05 07:33:53 PDT 
A couple of tests in html/rendering/widgets/button-layout/ are expecting <input type=submit|reset|button> to look the same as <button>, making them the same appearance would be a good first step.
Comment 1 Tim Nguyen (:ntim) 2022-04-05 07:39:05 PDT 
One important bug switching from button to push-button fixes is:

Code: <input type=button value="1&#10;2">

Testcase URL: data:text/html,%3Cinput type%3Dbutton value%3D"1%26%2310%3B2"%3E

Should appear the same as: <button>1<br>2</button>

Right now it appears as: <button>1</button>

Tested by html/rendering/widgets/button-layout/inline-level.html WPT
Comment 2 Tim Nguyen (:ntim) 2022-04-05 08:48:43 PDT 
<input type=button> does not respect author sizing (padding/height/etc.), while <button> does. <button> behavior is more in line with other browsers, switching from push-button to button appearance fixes this.
Comment 3 Tim Nguyen (:ntim) 2022-04-05 10:21:07 PDT 
Created attachment 456715 [details]
Patch
Comment 4 Radar WebKit Bug Importer 2022-04-12 07:34:15 PDT 
<rdar://problem/91624840>
Comment 5 Tim Nguyen (:ntim) 2022-07-01 19:04:20 PDT 
*** Bug 190521 has been marked as a duplicate of this bug. ***
Comment 6 Tim Nguyen (:ntim) 2022-11-24 12:09:16 PST 
Created attachment 463716 [details]
Patch
Comment 7 Tim Nguyen (:ntim) 2022-12-29 19:45:53 PST 
Work needed here is mostly rebaselining, it would be nice to fix this so multi-line text and padding are respected for `<input type="submit/reset/button">`.
Comment 8 Tim Nguyen (:ntim) 2022-12-29 19:46:32 PST 
(also makes vertical form controls slightly easier to implement)
Comment 9 Tim Nguyen (:ntim) 2023-01-10 01:21:10 PST 
Pull request: https://github.com/WebKit/WebKit/pull/8440
Comment 10 EWS 2023-01-10 16:59:44 PST 
Committed 258754@main (1a0105921def): <https://commits.webkit.org/258754@main>

Reviewed commits have been landed. Closing PR #8440 and removing active labels.
Comment 11 Tim Nguyen (:ntim) 2023-01-10 17:38:12 PST 
*** Bug 224746 has been marked as a duplicate of this bug. ***
Comment 12 Ahmad Saleem 2023-03-29 10:13:11 PDT 
*** Bug 26804 has been marked as a duplicate of this bug. ***