Bug 238803

Summary:

[Forms] Use button instead of push-button appearance for input[type=submit|reset|button]

Product:

WebKit

Reporter:

Tim Nguyen (:ntim) <ntim>

Component:

CSS

Assignee:

Tim Nguyen (:ntim) <ntim>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

changseok, esprehn+autocc, ews-watchlist, glenn, jasneet, karlcow, kondapallykalyan, MatsPalmgren_bugz, pdr, vanita.barrett, webkit-bug-importer

Priority:

Keywords:

BrowserCompat, InRadar, WPTImpact

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=224746

Bug Depends on:

Bug Blocks:

245355

Attachments:

Description	Flags
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-

Tim Nguyen (:ntim)

Reported 2022-04-05 07:33:53 PDT

A couple of tests in html/rendering/widgets/button-layout/ are expecting <input type=submit|reset|button> to look the same as <button>, making them the same appearance would be a good first step.

Attachments
Patch (1.52 KB, patch) 2022-04-05 10:21 PDT, Tim Nguyen (:ntim)	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (9.84 KB, patch) 2022-11-24 12:09 PST, Tim Nguyen (:ntim)	ews-feeder: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Tim Nguyen (:ntim)

Comment 1 2022-04-05 07:39:05 PDT

One important bug switching from button to push-button fixes is: Code: <input type=button value="1
2"> Testcase URL: data:text/html,%3Cinput type%3Dbutton value%3D"1%26%2310%3B2"%3E Should appear the same as: <button>1<br>2</button> Right now it appears as: <button>1</button> Tested by html/rendering/widgets/button-layout/inline-level.html WPT

Tim Nguyen (:ntim)

Comment 2 2022-04-05 08:48:43 PDT

<input type=button> does not respect author sizing (padding/height/etc.), while <button> does. <button> behavior is more in line with other browsers, switching from push-button to button appearance fixes this.

Tim Nguyen (:ntim)

Comment 3 2022-04-05 10:21:07 PDT

Created attachment 456715 [details] Patch

Radar WebKit Bug Importer

Comment 4 2022-04-12 07:34:15 PDT

<rdar://problem/91624840>

Tim Nguyen (:ntim)

Comment 5 2022-07-01 19:04:20 PDT

*** Bug 190521 has been marked as a duplicate of this bug. ***

Tim Nguyen (:ntim)

Comment 6 2022-11-24 12:09:16 PST

Created attachment 463716 [details] Patch

Tim Nguyen (:ntim)

Comment 7 2022-12-29 19:45:53 PST

Work needed here is mostly rebaselining, it would be nice to fix this so multi-line text and padding are respected for `<input type="submit/reset/button">`.

Tim Nguyen (:ntim)

Comment 8 2022-12-29 19:46:32 PST

(also makes vertical form controls slightly easier to implement)

Tim Nguyen (:ntim)

Comment 9 2023-01-10 01:21:10 PST

Pull request: https://github.com/WebKit/WebKit/pull/8440

EWS

Comment 10 2023-01-10 16:59:44 PST

Committed 258754@main (1a0105921def): <https://commits.webkit.org/258754@main> Reviewed commits have been landed. Closing PR #8440 and removing active labels.

Tim Nguyen (:ntim)

Comment 11 2023-01-10 17:38:12 PST

*** Bug 224746 has been marked as a duplicate of this bug. ***

Ahmad Saleem

Comment 12 2023-03-29 10:13:11 PDT

*** Bug 26804 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.