Bug 238793

Summary:

update-angle output varies unpredictably due to blob hash abbreviation

Product:

WebKit

Reporter:

Kimmo Kinnunen <kkinnunen>

Component:

ANGLE

Assignee:

Kimmo Kinnunen <kkinnunen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dino, ews-watchlist, kbr, kkinnunen, koivisto, kondapallykalyan, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Safari 15

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

238794

Bug Blocks:

Attachments:

Description	Flags
Patch	none

Description Kimmo Kinnunen 2022-04-05 01:03:42 PDT

update-angle output varies unpredictably due to blob hash abbreviation
the script should use diff --full-index

Comment 1 Kimmo Kinnunen 2022-04-05 01:23:50 PDT

Created attachment 456683 [details]
Patch

Comment 2 EWS Watchlist 2022-04-05 01:25:23 PDT

Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE

Comment 3 Antti Koivisto 2022-04-05 01:41:58 PDT

Comment on attachment 456683 [details]
Patch

rs=me

Comment 4 EWS 2022-04-05 02:41:21 PDT

Committed r292388 (249253@main): <https://commits.webkit.org/249253@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456683 [details].

Comment 5 Radar WebKit Bug Importer 2022-04-05 02:42:14 PDT

<rdar://problem/91284547>