| Summary: | [CSS-Contain] Add support for contain: inline-size | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, koivisto, kondapallykalyan, macpherson, menard, pdr, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
zalan
2022-04-04 20:37:19 PDT
Created attachment 456666 [details]
Patch
Comment on attachment 456666 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456666&action=review > Source/WebCore/rendering/RenderBlockFlow.cpp:348 > + if (!(shouldApplySizeContainment(*this) || shouldApplyInlineSizeContainment(*this))) { bool shouldApplyContainment = might make this more readable. Comment on attachment 456666 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456666&action=review > LayoutTests/imported/w3c/web-platform-tests/css/css-contain/parsing/contain-computed-expected.txt:16 > +FAIL Property contain value 'inline-size layout style paint' assert_equals: expected "inline-size layout style paint" but got "layout style paint inline-size" Maybe these could be arranged to canonical order trivially? Created attachment 456698 [details]
Patch
Committed r292394 (249259@main): <https://commits.webkit.org/249259@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456698 [details]. |