Bug 238762

Summary: Remove the 'general_directory_for_storage' system feature flag
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, sihui_liu, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sihui_liu: review+

Description Tim Horton 2022-04-04 13:55:42 PDT
Remove the 'general_directory_for_storage' system feature flag
Comment 1 Tim Horton 2022-04-04 13:55:57 PDT
Created attachment 456624 [details]
Patch
Comment 2 Tim Horton 2022-04-04 13:56:55 PDT
If you need a for-debugging-only way to disable this, perhaps a user default, or WebPreferencesDebug preference? (both suggestions are only valid if you're OK with apps having the power to turn this flag on and off themselves).
Comment 3 Tim Horton 2022-04-04 15:18:19 PDT
Sihui points out that `internalFeatureEnabled` somewhat-questionably already reads from defaults, so this should be OK as it stands.
Comment 4 Sihui Liu 2022-04-04 15:53:55 PDT
Comment on attachment 456624 [details]
Patch

r=me, given that we should still be able to turn it off with NSUserDefaults.
Comment 5 Tim Horton 2022-04-04 16:06:38 PDT
Committed r292355 (249220@trunk): <https://commits.webkit.org/249220@trunk>
Comment 6 Radar WebKit Bug Importer 2022-04-04 16:07:15 PDT
<rdar://problem/91266474>