| Summary: | [PlayStation] Enable libpas. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Basuke Suzuki <Basuke.Suzuki> | ||||||||
| Component: | bmalloc | Assignee: | Basuke Suzuki <Basuke.Suzuki> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | annulen, Basuke.Suzuki, don.olmstead, ews-watchlist, ggaren, gyuyoung.kim, ryuan.choi, sergio, stephan.szabo, webkit-bug-importer, ysuzuki | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Basuke Suzuki
2022-04-04 12:14:40 PDT
Created attachment 456604 [details]
PATCH
Created attachment 456605 [details]
PATCH
Comment on attachment 456605 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=456605&action=review Nice, some early comments. > Source/bmalloc/libpas/src/libpas/pas_platform.h:178 > +#if !defined(alignof) > +#define alignof _Alignof > +#endif Let's define `PAS_ALIGNOF` > Source/bmalloc/libpas/src/libpas/pas_thread_local_cache.c:53 > +#if PAS_PLATFORM(PLAYSTATION) > +#include <pthread_np.h> > +#define pthread_getname_np(a, b, c) pthread_get_name_np(a, b) > +#endif Probably you can just add this switch in dump_thread_diagnostics function directly since it is the only one function using pthread_get_name_np. Comment on attachment 456605 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=456605&action=review Thanks for the quick comment. >> Source/bmalloc/libpas/src/libpas/pas_platform.h:178 >> +#endif > > Let's define `PAS_ALIGNOF` Good idea. Thanks. Our some of our old platform doesn't support C11 correctly. >> Source/bmalloc/libpas/src/libpas/pas_thread_local_cache.c:53 >> +#endif > > Probably you can just add this switch in dump_thread_diagnostics function directly since it is the only one function using pthread_get_name_np. Sounds good. Created attachment 456633 [details]
PATCH
Comment on attachment 456633 [details]
PATCH
r=me
Comment on attachment 456633 [details]
PATCH
All green. Thanks! Yusuke!
Committed r292407 (249270@main): <https://commits.webkit.org/249270@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456633 [details]. |