Bug 238736

Summary: Simplify / Optimize the whitespace cache implementation
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, darin, esprehn+autocc, ews-watchlist, ggaren, gyuyoung.kim, heycam, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Follow-up to fix style darin: review+

Description Chris Dumez 2022-04-04 07:18:12 PDT 
Simplify / Optimize the whitespace cache implementation.
Comment 1 Chris Dumez 2022-04-04 07:23:35 PDT 
Created attachment 456568 [details]
Patch
Comment 2 Sam Weinig 2022-04-04 09:43:13 PDT 
Comment on attachment 456568 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456568&action=review

> Source/WebCore/html/parser/HTMLConstructionSite.h:245
> +    WhitespaceCache() :
> +        m_atoms(maximumCachedStringLength)
> +    { }

Unconventional style. Probably this:

WhitespaceCache()
    : m_atoms(maximumCachedStringLength)
{
}
Comment 3 Chris Dumez 2022-04-04 09:49:45 PDT 
(In reply to Sam Weinig from comment #2)
> Comment on attachment 456568 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=456568&action=review
> 
> > Source/WebCore/html/parser/HTMLConstructionSite.h:245
> > +    WhitespaceCache() :
> > +        m_atoms(maximumCachedStringLength)
> > +    { }
> 
> Unconventional style. Probably this:
> 
> WhitespaceCache()
>     : m_atoms(maximumCachedStringLength)
> {
> }

Ooops, my bad, not sure what happened there.
Comment 4 Chris Dumez 2022-04-04 10:10:17 PDT 
Created attachment 456584 [details]
Patch
Comment 5 EWS 2022-04-04 12:26:21 PDT 
Committed r292310 (249203@main): <https://commits.webkit.org/249203@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456584 [details].
Comment 6 Radar WebKit Bug Importer 2022-04-04 12:27:18 PDT 
<rdar://problem/91255370>
Comment 7 Darin Adler 2022-04-08 14:47:45 PDT 
Comment on attachment 456584 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456584&action=review

> Source/WebCore/html/parser/HTMLConstructionSite.h:52
> +namespace WebCore {
>  struct HTMLConstructionSiteTask {

Missing space here.
Comment 8 Chris Dumez 2022-04-08 14:48:46 PDT 
Comment on attachment 456584 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456584&action=review

>> Source/WebCore/html/parser/HTMLConstructionSite.h:52
>>  struct HTMLConstructionSiteTask {
> 
> Missing space here.

I can add a blank line between the namespace and the struct, assuming that's what you mean.
Comment 9 Chris Dumez 2022-04-08 14:51:33 PDT 
Reopening to attach new patch.
Comment 10 Chris Dumez 2022-04-08 14:51:54 PDT 
Created attachment 457121 [details]
Follow-up to fix style
Comment 11 Darin Adler 2022-04-08 15:02:29 PDT 
Comment on attachment 457121 [details]
Follow-up to fix style

View in context: https://bugs.webkit.org/attachment.cgi?id=457121&action=review

> Source/WebCore/html/parser/HTMLConstructionSite.h:52
>  namespace WTF {
> +
>  template<> struct VectorTraits<WebCore::AtomStringWithCode> : SimpleClassVectorTraits { };
> +
>  }

Not sure we needed these, but the others do seem important to look right.
Comment 12 Chris Dumez 2022-04-08 15:07:49 PDT 
Committed r292638 (249458@trunk): <https://commits.webkit.org/249458@trunk>