Bug 238701

Summary: Start replacing String(const char*) constructor with a String::fromLatin1(const char*) function
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web Template FrameworkAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, beidson, benjamin, changseok, cmarcelo, darin, dino, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, gyuyoung.kim, hi, hta, japhet, jer.noble, joepeck, jsbell, kangil.han, keith_miller, kondapallykalyan, macpherson, mark.lam, menard, mifenton, msaboff, pangle, pascoe, philipj, saam, sergio, tommyw, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 238693    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2022-04-02 12:58:12 PDT 
Replace String(const char*) constructor with a String::fromLatin1(const char*) function. It is more consistent with String::fromUTF8() and makes it clearer that input is treated as Latin-1.
Comment 1 Chris Dumez 2022-04-05 20:28:44 PDT 
Created attachment 456777 [details]
Patch
Comment 2 Chris Dumez 2022-04-05 21:44:41 PDT 
Created attachment 456782 [details]
Patch
Comment 3 Geoffrey Garen 2022-04-06 10:53:24 PDT 
Comment on attachment 456782 [details]
Patch

r=me
Comment 4 Chris Dumez 2022-04-06 12:05:36 PDT 
Comment on attachment 456782 [details]
Patch

Clearing flags on attachment: 456782

Committed r292487 (?): <https://commits.webkit.org/r292487>
Comment 5 Chris Dumez 2022-04-06 12:05:40 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2022-04-06 12:06:18 PDT 
<rdar://problem/91368828>