| Summary: | Fix the WebGPU-less build | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | mmaxfield, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Tim Horton
2022-04-01 18:56:47 PDT
Created attachment 456425 [details]
Patch
Comment on attachment 456425 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456425&action=review > Source/WebCore/Configurations/WebCore.xcconfig:158 > -WK_NETWORK_EXTENSION_LD_FLAGS = $(WK_NETWORK_EXTENSION_LD_FLAGS_$(WK_PLATFORM_NAME)); > -WK_NETWORK_EXTENSION_LD_FLAGS_iphoneos = -framework NetworkExtension; > -WK_NETWORK_EXTENSION_LD_FLAGS_iphonesimulator = -framework NetworkExtension; > -WK_NETWORK_EXTENSION_LD_FLAGS_watchos = -framework NetworkExtension; > -WK_NETWORK_EXTENSION_LD_FLAGS_watchsimulator = -framework NetworkExtension; > -WK_NETWORK_EXTENSION_LD_FLAGS_maccatalyst = -framework NetworkExtension; > -WK_NETWORK_EXTENSION_LD_FLAGS_macosx = -weak_framework NetworkExtension; > +WK_NETWORK_EXTENSION_LDFLAGS = $(WK_NETWORK_EXTENSION_LDFLAGS_$(WK_PLATFORM_NAME)); > +WK_NETWORK_EXTENSION_LDFLAGS_iphoneos = -framework NetworkExtension; > +WK_NETWORK_EXTENSION_LDFLAGS_iphonesimulator = -framework NetworkExtension; > +WK_NETWORK_EXTENSION_LDFLAGS_watchos = -framework NetworkExtension; > +WK_NETWORK_EXTENSION_LDFLAGS_watchsimulator = -framework NetworkExtension; > +WK_NETWORK_EXTENSION_LDFLAGS_maccatalyst = -framework NetworkExtension; > +WK_NETWORK_EXTENSION_LDFLAGS_macosx = -weak_framework NetworkExtension; Please don't do this in this patch. Please do this in another patch. Created attachment 456426 [details]
Patch
Comment on attachment 456426 [details]
Patch
r=mews
(In reply to Myles C. Maxfield from comment #2) > Comment on attachment 456425 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=456425&action=review > > > Source/WebCore/Configurations/WebCore.xcconfig:158 > > -WK_NETWORK_EXTENSION_LD_FLAGS = $(WK_NETWORK_EXTENSION_LD_FLAGS_$(WK_PLATFORM_NAME)); > > -WK_NETWORK_EXTENSION_LD_FLAGS_iphoneos = -framework NetworkExtension; > > -WK_NETWORK_EXTENSION_LD_FLAGS_iphonesimulator = -framework NetworkExtension; > > -WK_NETWORK_EXTENSION_LD_FLAGS_watchos = -framework NetworkExtension; > > -WK_NETWORK_EXTENSION_LD_FLAGS_watchsimulator = -framework NetworkExtension; > > -WK_NETWORK_EXTENSION_LD_FLAGS_maccatalyst = -framework NetworkExtension; > > -WK_NETWORK_EXTENSION_LD_FLAGS_macosx = -weak_framework NetworkExtension; > > +WK_NETWORK_EXTENSION_LDFLAGS = $(WK_NETWORK_EXTENSION_LDFLAGS_$(WK_PLATFORM_NAME)); > > +WK_NETWORK_EXTENSION_LDFLAGS_iphoneos = -framework NetworkExtension; > > +WK_NETWORK_EXTENSION_LDFLAGS_iphonesimulator = -framework NetworkExtension; > > +WK_NETWORK_EXTENSION_LDFLAGS_watchos = -framework NetworkExtension; > > +WK_NETWORK_EXTENSION_LDFLAGS_watchsimulator = -framework NetworkExtension; > > +WK_NETWORK_EXTENSION_LDFLAGS_maccatalyst = -framework NetworkExtension; > > +WK_NETWORK_EXTENSION_LDFLAGS_macosx = -weak_framework NetworkExtension; > > Please don't do this in this patch. Please do this in another patch. ap got me in a drive-by-fix mood in bug 238655, but yes, you're right, I've posted a version with that reverted. |