| Summary: | [CMake] Make PlayStation WebDriver build dependent on WPE Backend | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||
| Component: | CMake | Assignee: | Don Olmstead <don.olmstead> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | annulen, ews-watchlist, gyuyoung.kim, ross.kirsling, ryuan.choi, sergio, stephan.szabo | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Don Olmstead
2022-04-01 11:55:12 PDT
Created attachment 456391 [details]
Patch
Comment on attachment 456391 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456391&action=review > Source/WebKit/PlatformPlayStation.cmake:110 > + UIProcess/Automation/libwpe/WebAutomationSessionLibWPE.cpp I don't think this is correct. We should not think that webprocess will only be on for WPE even with the upstream OptionsPlayStation only setting it on in that combination because the downstream merged state will also have it on but doesn't have the wpe support. Pull request: https://github.com/WebKit/WebKit/pull/8217 Committed 258489@main (e217508ca2f1): <https://commits.webkit.org/258489@main> Reviewed commits have been landed. Closing PR #8217 and removing active labels. |