Bug 238581

Summary:

REGRESSION(r292107): [ Mac iOS ] http/tests/paymentrequest/updateWith-shippingOptions.https.html is a constant text failure

Product:

WebKit

Reporter:

Dawn Morningstar <Morningstar>

Component:

New Bugs

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, hi, webkit-bot-watchers-bugzilla, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=238306
https://bugs.webkit.org/show_bug.cgi?id=243083

Attachments:

Description	Flags
[fast-cq] Patch	none

Description Dawn Morningstar 2022-03-30 16:49:44 PDT

http/tests/paymentrequest/updateWith-shippingOptions.https.html
Is a constant text failure on all all queues.

regression appears to be r292107, but its notable that r291811 was also a regression for this test; causing a constant failure on Monterey specifically.

HISTORY:
https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Fpaymentrequest%2FupdateWith-shippingOptions.https.html

DIFF:
--- /Volumes/Data/worker/bigsur-release-tests-wk2/build/layout-test-results/http/tests/webAPIStatistics/canvas-read-and-write-data-collection-expected.txt
+++ /Volumes/Data/worker/bigsur-release-tests-wk2/build/layout-test-results/http/tests/webAPIStatistics/canvas-read-and-write-data-collection-actual.txt
@@ -9,3 +9,11 @@
     isPrevalentResource: No
     isVeryPrevalentResource: No
     dataRecordsRemoved: 0
+Registrable domain: nullOrigin
+    hadUserInteraction: No
+    mostRecentUserInteraction: -1
+    grandfathered: No
+    IsScheduledForAllButCookieDataRemoval: No
+    isPrevalentResource: No
+    isVeryPrevalentResource: No
+    dataRecordsRemoved: 0

DIFF-URL:
https://build.webkit.org/results/Apple-BigSur-Release-WK2-Tests/r292107%20(8585)/http/tests/webAPIStatistics/canvas-read-and-write-data-collection-diff.txt

Comment 1 Radar WebKit Bug Importer 2022-03-30 16:51:05 PDT

<rdar://problem/91074265>

Comment 2 zalan 2022-03-30 18:10:32 PDT

I am puzzled by this regression point and if it truly regressed at r291811, then the original author should change the test so that it's not sensitive to a text measuring change like this.

Comment 3 Devin Rousso 2022-03-31 11:23:39 PDT

yeah im not sure how this relates to r291811 at all

i think r292107 is really the cause

Comment 4 Devin Rousso 2022-03-31 11:27:14 PDT

Created attachment 456259 [details]
[fast-cq] Patch

Comment 5 Dawn Morningstar 2022-03-31 11:29:55 PDT

Noticed this DIFF is incorrect.

Must have clicked an incorrect link.

Correct DIFF:

--- /Volumes/Data/worker/bigsur-release-tests-wk2/build/layout-test-results/http/tests/paymentrequest/updateWith-shippingOptions.https-expected.txt
+++ /Volumes/Data/worker/bigsur-release-tests-wk2/build/layout-test-results/http/tests/paymentrequest/updateWith-shippingOptions.https-actual.txt
@@ -1,5 +1,5 @@
 CONSOLE MESSAGE: WebKit currently uses the first shipping option even if other shipping options are marked as selected.
 
 PASS Calling `updateWith` with a new `shippingOptions` without `requestShipping` should not update any values.
-FAIL Calling `updateWith` with a new `shippingOptions` should not update any other values. assert_equals: selected shipping option should change expected "shippingId4" but got "shippingId3"
+FAIL Calling `updateWith` with a new `shippingOptions` should not update any other values. assert_equals: shipping option 0 selected should change expected (boolean) false but got (undefined) undefined
 

Correct DIFF URL:
https://build.webkit.org/results/Apple-BigSur-Release-WK2-Tests/r292156%20(8603)/http/tests/paymentrequest/updateWith-shippingOptions.https-diff.txt

Comment 6 Dawn Morningstar 2022-03-31 11:31:29 PDT

(In reply to Devin Rousso from comment #3)
> yeah im not sure how this relates to r291811 at all
> 
> i think r292107 is really the cause

I think r292107 is the real cause as well, but I did notice looking at the history, a strange failure after r291811.

Comment 7 Chris Dumez 2022-03-31 14:03:21 PDT

Comment on attachment 456259 [details]
[fast-cq] Patch

Clearing flags on attachment: 456259

Committed r292173 (249080@trunk): <https://commits.webkit.org/249080@trunk>

Comment 8 Chris Dumez 2022-03-31 14:03:23 PDT

All reviewed patches have been landed.  Closing bug.

Comment 9 Dawn Morningstar 2022-04-06 17:15:44 PDT

*** Bug 238908 has been marked as a duplicate of this bug. ***