Bug 238573

Summary: Add a placeholder for some additional Captive Portal mode settings
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, ggaren, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Description Brent Fulgham 2022-03-30 13:50:29 PDT 
Add a macro placeholder for some future Captive Portal settings.
Comment 1 Radar WebKit Bug Importer 2022-03-30 13:51:14 PDT 
<rdar://problem/91064718>
Comment 2 Brent Fulgham 2022-03-30 13:54:25 PDT 
Created attachment 456171 [details]
Patch
Comment 3 Wenson Hsieh 2022-03-30 14:17:43 PDT 
Comment on attachment 456171 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456171&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:4106
> +    CAPTIVE_PORTAL_WEB_PAGE_ADDITIONS();

Could we factor this out into a static helper function instead?
Comment 4 Brent Fulgham 2022-03-30 14:46:40 PDT 
Created attachment 456178 [details]
Patch
Comment 5 Tim Horton 2022-03-30 15:02:40 PDT 
Comment on attachment 456178 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456178&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:396
> +#import <WebKitAdditions/WebPageAdditions.h>

This should be a .cpp file.
Comment 6 Brent Fulgham 2022-03-30 15:37:26 PDT 
Comment on attachment 456178 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456178&action=review

>> Source/WebKit/WebProcess/WebPage/WebPage.cpp:396
>> +#import <WebKitAdditions/WebPageAdditions.h>
> 
> This should be a .cpp file.

Will fix.
Comment 7 Brent Fulgham 2022-03-30 15:51:48 PDT 
Created attachment 456182 [details]
Patch
Comment 8 Wenson Hsieh 2022-03-31 08:32:11 PDT 
Comment on attachment 456182 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456182&action=review

> Source/WebKit/ChangeLog:12
> +        (WebKit::adjustSettingsForCaptivePortal): Call new placeholder macro.

s/macro/helper function/
Comment 9 Brent Fulgham 2022-03-31 10:20:56 PDT 
Created attachment 456252 [details]
Patch for landing
Comment 10 EWS 2022-03-31 13:01:53 PDT 
Committed r292165 (249072@main): <https://commits.webkit.org/249072@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456252 [details].