| Summary: | [CSS contain] Containment disables the special handling of the HTML body element for overflow viewport propagation [part2] | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, rbuis, simon.fraser, webkit-bug-importer, zalan | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | Other | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
zalan
2022-03-30 13:22:06 PDT
Created attachment 456170 [details]
Patch
Comment on attachment 456170 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456170&action=review > Source/WebCore/rendering/RenderBox.cpp:514 > + // (4) No containment is set neither on the body nor on the html document element. neither/nor -> either/or Created attachment 456172 [details]
Patch
Created attachment 456194 [details]
Patch
Nice! When I was working on these tests I could not figure out how to fix these three... (In reply to Rob Buis from comment #5) > Nice! When I was working on these tests I could not figure out how to fix > these three... I am going through this list https://wpt.fyi/results/css/css-contain?label=experimental&label=master&product=chrome&product=firefox&product=safari&aligned&q=label%3Ainterop-2022-contain to see if we can turn some of the red to green. (In reply to zalan from comment #6) > (In reply to Rob Buis from comment #5) > > Nice! When I was working on these tests I could not figure out how to fix > > these three... > I am going through this list > https://wpt.fyi/results/css/css- > contain?label=experimental&label=master&product=chrome&product=firefox&produc > t=safari&aligned&q=label%3Ainterop-2022-contain to see if we can turn some > of the red to green. Sadly I've already seen some non-actionable/needs more thinking failures e.g. https://trac.webkit.org/changeset/292140/webkit Committed r292157 (249064@main): <https://commits.webkit.org/249064@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456194 [details]. |