| Summary: | Remove EXPERIMENTAL_FEATURES flag on Cocoa platforms | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | darin, don.olmstead, ews-watchlist, hi, joepeck, pangle, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Alex Christensen
2022-03-30 12:06:17 PDT
Created attachment 456161 [details]
Patch
For our CMake ports I'm open to just putting it as ON instead of basing it on the flags. So as an example we have ENABLE_SERVICE_WORKERS as an experimental feature then in this brave new world we'd just make sure that its not enabled by default in the preferences. Is there anything else we should be aware of here when migrating off of ENABLE_EXPERIMENTAL_FEATURES? I guess Source/cmake/WebKitFeatures.cmake and Source/cmake/Options*.cmake use this for something else. I'm going to leave that as it is and just remove EXPERIMENTAL_FEATURES from the source. Created attachment 456184 [details]
Patch
Committed r292156 (249063@main): <https://commits.webkit.org/249063@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456184 [details]. |