| Summary: | Split streaming of AX trees from the class AXLogger. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andres Gonzalez <andresg_22> | ||||||
| Component: | Accessibility | Assignee: | Andres Gonzalez <andresg_22> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, tyler_w, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Andres Gonzalez
2022-03-30 06:51:35 PDT
Created attachment 456117 [details]
Patch
Comment on attachment 456117 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456117&action=review > Source/WebCore/accessibility/AXLogger.cpp:568 > + stream.dumpProperty("roleValue", role); I know this isn't new with your patch, but I wonder if it would be better to shorten this to role instead of roleValue to make the logs a little less noisy. I get that roleValue is the name of the method in AXCoreObject, but in this case I don't think it's necessary to include the full method name. Created attachment 456137 [details]
Patch
(In reply to Tyler Wilcock from comment #3) > Comment on attachment 456117 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=456117&action=review > > > Source/WebCore/accessibility/AXLogger.cpp:568 > > + stream.dumpProperty("roleValue", role); > > I know this isn't new with your patch, but I wonder if it would be better to > shorten this to role instead of roleValue to make the logs a little less > noisy. I get that roleValue is the name of the method in AXCoreObject, but > in this case I don't think it's necessary to include the full method name. Done. Committed r292142 (249049@main): <https://commits.webkit.org/249049@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456137 [details]. |