Bug 238548

Summary: Notification should be exposed to ServiceWorker contexts
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, cdumez, esprehn+autocc, ews-watchlist, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Rebasing none

Description youenn fablet 2022-03-30 05:10:35 PDT 
Currently we can create Notification from a service worker even though Notification is not yet exposed.
We should also throw when constructor is called in a service worker context.
Comment 1 youenn fablet 2022-03-31 01:03:35 PDT 
Created attachment 456210 [details]
Patch
Comment 2 youenn fablet 2022-03-31 05:31:36 PDT 
Created attachment 456228 [details]
Patch
Comment 3 youenn fablet 2022-03-31 06:32:00 PDT 
Created attachment 456232 [details]
Patch
Comment 4 Chris Dumez 2022-03-31 08:20:29 PDT 
Comment on attachment 456232 [details]
Patch

r=me
Comment 5 youenn fablet 2022-04-01 01:34:55 PDT 
Created attachment 456336 [details]
Rebasing
Comment 6 EWS 2022-04-01 04:49:56 PDT 
Committed r292216 (249119@main): <https://commits.webkit.org/249119@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456336 [details].
Comment 7 Radar WebKit Bug Importer 2022-04-01 04:50:17 PDT 
<rdar://problem/91156510>