| Summary: | Web Inspector: Sources: the mapped file URL of a Response Local Override should be clickable | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ews-watchlist, hi, inspector-bugzilla-changes, joepeck, pangle, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Bug Depends on: | 238236 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Devin Rousso
2022-03-29 18:31:32 PDT
Created attachment 456084 [details]
[fast-cq] Patch
Comment on attachment 456084 [details] [fast-cq] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456084&action=review rs=me with one suggestion – also the build failures on GTK and others look real. > Source/WebCore/ChangeLog:11 > + (WebCore::InspectorFrontendHost::selectFileExternally): Added. Just one overarching question throughout: can we consider naming this `revealFileExternally` (and changing all the other method names to match)? Perhaps that is too much Mac influence here, but in general I see this sort of action behind a "Reveal in [...]" menu item in apps. `select`, in my opinion, is somewhat ambiguous with showing a file chooser to let someone choose (or "select") a file. Created attachment 456133 [details]
[fast-cq] Patch
Committed r292120 (249033@main): <https://commits.webkit.org/249033@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456133 [details]. |