Bug 238529

Summary: Test passing in offset for searchFunction.
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED INVALID    
Severity: Normal CC: darin, ews-watchlist, mifenton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ews-feeder: commit-queue-

Megan Gardner
Reported 2022-03-29 16:16:35 PDT
Test passing in offset for searchFunction.
Attachments
Patch (2.59 KB, patch)
2022-03-29 16:18 PDT, Megan Gardner 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2022-03-29 16:18:08 PDT
Created attachment 456077 [details] Patch
Darin Adler
Comment 2 2022-03-29 17:31:07 PDT
Comment on attachment 456077 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456077&action=review Looks right. > Source/WebCore/editing/VisibleUnits.cpp:1073 > - return ubrk_preceding(sentenceBreakIterator(text), text.length()); > + return ubrk_preceding(sentenceBreakIterator(text), offset); Do we need to clamp the offset so to guarantee it’s <= length? > Source/WebCore/editing/VisibleUnits.cpp:1096 > - return ubrk_preceding(sentenceBreakIterator(text), text.length()); > + return ubrk_preceding(sentenceBreakIterator(text), offset); Same question.
Megan Gardner
Comment 3 2022-04-05 13:44:52 PDT
Failed experiment.
Note You need to log in before you can comment on or make changes to this bug.