Bug 238510

Summary: [LibWPE] Guard libxkbcommon code with WPE_ENABLE_XKB
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: PlatformAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, aperez, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch none

Description Don Olmstead 2022-03-29 09:53:40 PDT 
libwpe added an ENABLE flag for support of XKB.
Comment 1 Don Olmstead 2022-03-29 10:05:47 PDT Comment hidden (obsolete)
Comment 2 Don Olmstead 2022-03-29 10:19:06 PDT 
Created attachment 456040 [details]
Patch
Comment 3 Adrian Perez 2022-03-29 12:31:39 PDT 
Comment on attachment 456040 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456040&action=review

> Source/WebKit/UIProcess/Automation/libwpe/WebAutomationSessionLibWPE.cpp:152
>      struct wpe_input_xkb_keymap_entry* entries;

Meh. Too bad we don't have something like GUniqueOutPtr which would
call free() instead of g_free(); it would have been perfect to use
here instead of having the one line of guarded code below 🤷‍♂️️
Comment 4 EWS 2022-03-29 13:26:00 PDT 
Committed r292064 (248998@main): <https://commits.webkit.org/248998@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456040 [details].
Comment 5 Radar WebKit Bug Importer 2022-03-29 13:27:16 PDT 
<rdar://problem/91001968>