| Summary: | Move AuxiliaryProcess::createIPCConnectionPair to IPC::Connection | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> | ||||||||
| Component: | WebKit2 | Assignee: | Kimmo Kinnunen <kkinnunen> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | cdumez, ews-watchlist, hi, joepeck, kkinnunen, pangle, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 237674 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Kimmo Kinnunen
2022-03-29 07:00:41 PDT
Created attachment 456022 [details]
Patch
Created attachment 456024 [details]
Patch
Comment on attachment 456024 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456024&action=review > Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp:105 > + m_backendConnection = IPC::Connection::createServerConnection(connectionIdentifiers->server, *this); In this function, before code reuse it - created the port - set the MACH_MSG_TYPE_MAKE_SEND right - sent the port right with MACH_MSG_TYPE_MOVE_SEND Attachment disposition After code reuse: - created the port - sent the port right with MACH_MSG_TYPE_MAKE_SEND Attachment disposition I think these two should be equivalent? Created attachment 456032 [details]
Patch
Comment on attachment 456032 [details]
Patch
r=me
Committed r292102 (249022@main): <https://commits.webkit.org/249022@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456032 [details]. |