| Summary: | IPC::Connection::Connection() is not usable from non-main threads | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> | ||||
| Component: | WebKit2 | Assignee: | Kimmo Kinnunen <kkinnunen> | ||||
| Status: | NEW --- | ||||||
| Severity: | Normal | CC: | cdumez, kkinnunen, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 238515 | ||||||
| Attachments: |
|
||||||
|
Description
Kimmo Kinnunen
2022-03-29 02:23:13 PDT
Created attachment 456047 [details]
Patch
Comment on attachment 456047 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456047&action=review > Source/WebKit/ChangeLog:8 > + Make it possible to instantiate Connection from non-main threads. Is it OK that even we can now construct an IPC::Connection off the main thread, it will still always get destroyed on the main thread (meaning that the destruction thread differs from the construction thread)? Comment on attachment 456047 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456047&action=review >> Source/WebKit/ChangeLog:8 >> + Make it possible to instantiate Connection from non-main threads. > > Is it OK that even we can now construct an IPC::Connection off the main thread, it will still always get destroyed on the main thread (meaning that the destruction thread differs from the construction thread)? Yes, I think it is sound. This also preserves the assertions in the destructor. However, currently the feature of constructing in arbitrary thread is not that useful. Also, the feature in practice cannot be used until more of the features (all?) are made thread agnostic. This means the work in this patch is mostly useful only at the point when ~Connection runs in arbitrary thread. |