| Summary: | [JSC] Remove ExecutableToCodeBlockEdge | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||||||||||||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||
| Severity: | Normal | CC: | annulen, ews-watchlist, gyuyoung.kim, keith_miller, mark.lam, msaboff, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer | ||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
Yusuke Suzuki
2022-03-28 21:03:44 PDT
Created attachment 455987 [details]
Patch
Created attachment 456188 [details]
Patch
Created attachment 456191 [details]
Patch
Created attachment 456195 [details]
Patch
Created attachment 456197 [details]
Patch
Created attachment 456200 [details]
Patch
Created attachment 456206 [details]
Patch
Created attachment 456262 [details]
Patch
Comment on attachment 456262 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456262&action=review r=me with some comments. > Source/JavaScriptCore/heap/Heap.h:1075 > + struct ScriptExecutableSpaceAndSet { Nit: Maybe this should be ScriptExecutableSpaceAndSets* since there's more than one set in here. > Source/JavaScriptCore/runtime/FunctionExecutable.cpp:76 > + // If either of CodeBlocks is not marked yet, we will run output-constraints. Nit: If either CodeBlock is not marked yet > Source/JavaScriptCore/runtime/GlobalExecutable.cpp:46 > + // If the CodeBlocks is not marked yet, we will run output-constraints. Nit: not plural. It should be CodeBlock. Comment on attachment 456262 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456262&action=review Thank you! >> Source/JavaScriptCore/heap/Heap.h:1075 >> + struct ScriptExecutableSpaceAndSet { > > Nit: Maybe this should be ScriptExecutableSpaceAndSets* since there's more than one set in here. Right, fixed. >> Source/JavaScriptCore/runtime/FunctionExecutable.cpp:76 >> + // If either of CodeBlocks is not marked yet, we will run output-constraints. > > Nit: If either CodeBlock is not marked yet Fixed. >> Source/JavaScriptCore/runtime/GlobalExecutable.cpp:46 >> + // If the CodeBlocks is not marked yet, we will run output-constraints. > > Nit: not plural. It should be CodeBlock. Fixed. mac bots are getting stuck, and I cannot get it tested. Landing it since previous mac-wk2 was green (and mac-AS-debug-wk2 failures are fixed locally). Committed r292191 (249094@trunk): <https://commits.webkit.org/249094@trunk> |