| Summary: | [GLIB] Ubuntu LTS build broken after r291956 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Diego Pino <dpino> | ||||||||
| Component: | New Bugs | Assignee: | Diego Pino <dpino> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | changseok, darin, esprehn+autocc, ews-watchlist, glenn, jfernandez, kondapallykalyan, mattwoodrow, pdr, rego, svillar, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Diego Pino
2022-03-28 19:29:09 PDT
Created attachment 455982 [details]
Patch
Ubuntu LTS build bot error:
```
../../Source/WebCore/rendering/style/StyleGridData.h:47:59: error: ‘bool WebCore::GridTrackEntrySubgrid::operator==(const WebCore::GridTrackEntrySubgrid&) const’ cannot be defaulted
47 | bool operator==(const GridTrackEntrySubgrid&) const = default;
| ^~~~~~~
../../Source/WebCore/rendering/style/StyleGridData.h:50:58: error: ‘bool WebCore::GridTrackEntryRepeat::operator==(const WebCore::GridTrackEntryRepeat&) const’ cannot be defaulted
50 | bool operator==(const GridTrackEntryRepeat&) const = default;
| ^~~~~~~
../../Source/WebCore/rendering/style/StyleGridData.h:56:62: error: ‘bool WebCore::GridTrackEntryAutoRepeat::operator==(const WebCore::GridTrackEntryAutoRepeat&) const’ cannot be defaulted
56 | bool operator==(const GridTrackEntryAutoRepeat&) const = default;
| ^~~~~~~
```
https://build.webkit.org/#/builders/68/builds/12315/steps/8/logs/stdio
Created attachment 455998 [details]
Patch
Comment on attachment 455998 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455998&action=review > Source/WebCore/ChangeLog:3 > + [GLIB] Ubuntu LTS build broken after r291956 There should not be a "[GLIB]" prefix on a bug like this. I know our rule might be confusing. A "you used a non-portable feature that GCC doesn’t support yet" bug doesn’t need a platform prefix. Or if it did have one, it would be "[GCC]". /Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Created attachment 456082 [details]
[fast-cq] Patch
Committed r292094 (249014@main): <https://commits.webkit.org/249014@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456082 [details]. |