Bug 238477

Summary:

[WebXR][Cocoa] Enable GL_OES_EGL_image extension when makeXRCompatible() is called on GL context

Product:

WebKit

Reporter:

Ada Chan <adachan>

Component:

New Bugs

Assignee:

Ada Chan <adachan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, changseok, dino, esprehn+autocc, ews-watchlist, gyuyoung.kim, kondapallykalyan, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Ada Chan 2022-03-28 16:41:59 PDT

[WebXR][Cocoa] Enable GL_OES_EGL_image extension when makeXRCompatible() is called on GL context

Comment 1 Ada Chan 2022-03-28 16:44:17 PDT

Created attachment 455969 [details]
Patch

Comment 2 Dean Jackson 2022-03-28 16:47:45 PDT

Comment on attachment 455969 [details]
Patch

It's probably safe to do this unconditionally.

Comment 3 Ada Chan 2022-03-28 17:05:48 PDT

(In reply to Dean Jackson from comment #2)
> Comment on attachment 455969 [details]
> Patch
> 
> It's probably safe to do this unconditionally.

The reason I did this with a guard is to match what's done here:
https://bugs.webkit.org/show_bug.cgi?id=228575

Comment 4 EWS 2022-03-28 20:07:16 PDT

Committed r292021 (248965@main): <https://commits.webkit.org/248965@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455969 [details].

Comment 5 Radar WebKit Bug Importer 2022-03-28 20:08:15 PDT

<rdar://problem/90960584>