Bug 238466

Summary:

REGRESSION(r291771): [ iOS ] Text sometimes draw with incorrect color

Product:

WebKit

Reporter:

Dawn Morningstar <Morningstar>

Component:

New Bugs

Assignee:

Said Abou-Hallawa <sabouhallawa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, mmaxfield, pdr, sabouhallawa, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=238278

Bug Depends on:

Bug Blocks:

236508

Attachments:

Description	Flags
BUG238466 Diff Images	none
Patch	simon.fraser: review+
Patch	none

Description Dawn Morningstar 2022-03-28 13:24:24 PDT

fast/html/marquee-scroll.html
Is a constant image failure on iOS 

Diff images will be attached, suspected regression point is r291771 due to history pointing to that point.

HISTORY:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&test=fast%2Fhtml%2Fmarquee-scroll.html&test=imported%2Fw3c%2Fweb-platform-tests%2Ffetch%2Fmetadata%2Fdownload.https.sub.html&test=media%2Fvideo-played-ranges-1.html

DIFF-URL:
https://build.webkit.org/results/Apple-iOS-15-Simulator-Release-WK2-Tests/r291771%20(1978)/fast/html/marquee-scroll-diffs.html

Comment 1 Radar WebKit Bug Importer 2022-03-28 13:27:10 PDT

<rdar://problem/90941790>

Comment 2 Dawn Morningstar 2022-03-28 13:29:45 PDT

Created attachment 455948 [details]
BUG238466 Diff Images

Comment 3 Simon Fraser (smfr) 2022-03-28 13:32:12 PDT

This is a GPU-process-related color failure

Comment 4 Dawn Morningstar 2022-03-28 13:38:32 PDT

(In reply to Simon Fraser (smfr) from comment #3)
> This is a GPU-process-related color failure

Indeed and I saw that r291771 is a GPU-process patch. Are we thinking revert or can this be fixed?

Comment 5 Simon Fraser (smfr) 2022-03-28 13:45:55 PDT

This is a bug that Said is working on.

Comment 6 Said Abou-Hallawa 2022-03-28 20:53:27 PDT

Created attachment 455986 [details]
Patch

Comment 7 Simon Fraser (smfr) 2022-03-28 22:19:40 PDT

Comment on attachment 455986 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455986&action=review

Are there any tests that have been marked as flakey that this fixes?

> Source/WebCore/ChangeLog:3
> +        REGRESSION(r291771): [ iOS ] Glyphs should only be recorded after setting the destination GraphicsContext

It's good if the bug title describes the user-visible symptom (e.g. "Text sometimes draw with incorrect color").

Comment 8 Said Abou-Hallawa 2022-03-29 01:32:07 PDT

Created attachment 456005 [details]
Patch

Comment 9 EWS 2022-03-29 02:44:15 PDT

Committed r292026 (248969@main): <https://commits.webkit.org/248969@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456005 [details].