Bug 238446

Summary: Issues with WPT exporter
Product: WebKit Reporter: Noam Rosenthal <noam>
Component: Tools / TestsAssignee: Noam Rosenthal <noam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, glenn, gsnedders, jbedard, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 216330    
Attachments:
Description Flags
Patch
none
Patch none

Description Noam Rosenthal 2022-03-28 04:37:47 PDT 
See https://bugs.webkit.org/show_bug.cgi?id=238373

Applying a patch from a bug doesn't do the right thing:

- It requires a \n at the end (https://bugs.webkit.org/show_bug.cgi?id=216603)
- It sometimes doesn't fetch the correct master branch, rather something from December 2021
- It thinks it needs to add -expected.html

Trying to run this command:
 ./Tools/Scripts/export-w3c-test-changes -b 238373
Comment 1 Noam Rosenthal 2022-03-28 05:40:27 PDT 
Created attachment 455906 [details]
Patch
Comment 2 youenn fablet 2022-03-28 06:24:42 PDT 
Comment on attachment 455906 [details]
Patch

Looks good but some webkitpy tests are failing.
Can you double check the tests (hopefully just a rebase).
Comment 3 Noam Rosenthal 2022-03-28 06:45:19 PDT 
Created attachment 455912 [details]
Patch
Comment 4 Noam Rosenthal 2022-03-28 06:49:00 PDT 
(In reply to youenn fablet from comment #2)
> Comment on attachment 455906 [details]
> Patch
> 
> Looks good but some webkitpy tests are failing.
> Can you double check the tests (hopefully just a rebase).

Done, needed to add -3 to the test.
Comment 5 EWS 2022-03-28 08:14:24 PDT 
Committed r291966 (248931@main): <https://commits.webkit.org/248931@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455912 [details].
Comment 6 Radar WebKit Bug Importer 2022-03-28 08:15:17 PDT 
<rdar://problem/90922769>
Comment 7 Tim Nguyen (:ntim) 2022-03-28 09:29:31 PDT 
*** Bug 216603 has been marked as a duplicate of this bug. ***
Comment 8 Tim Nguyen (:ntim) 2022-03-28 09:29:40 PDT 
*** Bug 216330 has been marked as a duplicate of this bug. ***