| Summary: | [WebGPU] Implement CommandEncoder::copyTextureToBuffer() according to the spec | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||||
| Component: | WebGPU | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | dino, djg, kkinnunen, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | 238428 | ||||||||||||
| Bug Blocks: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Myles C. Maxfield
2022-03-27 19:09:31 PDT
Created attachment 455876 [details]
Patch
Created attachment 455941 [details]
Patch
Created attachment 456217 [details]
Patch
Created attachment 456218 [details]
Patch
Comment on attachment 456218 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456218&action=review > Source/WebGPU/WebGPU/CommandEncoder.mm:359 > + // "Let srcTextureDesc be source.texture.[[descriptor]]." This is the first time I've seen this style of spec inclusion. Do we normally include quotation marks. The style I've seen is a link at the top of the function, and then the comments are simply copied in (with the spec items numbers, if needed) Comment on attachment 456218 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456218&action=review >> Source/WebGPU/WebGPU/CommandEncoder.mm:359 >> + // "Let srcTextureDesc be source.texture.[[descriptor]]." > > This is the first time I've seen this style of spec inclusion. Do we normally include quotation marks. > > The style I've seen is a link at the top of the function, and then the comments are simply copied in (with the spec items numbers, if needed) Without quotation marks, how do you know what's a quote and what isn't? You're not the first one to complain about this style, so maybe I should just get rid of all these kinds of comments altogether. I seem to be the only one that thinks they're valuable. I'll do it in a follow-up patch. Committed r292199 (249102@trunk): <https://commits.webkit.org/249102@trunk> |