Bug 238422

Summary: Drop unnecessary isReachableFromDOM() function in JSNodeCustom.cpp
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, darin, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch peng.liu6: review+, ews-feeder: commit-queue-

Description Chris Dumez 2022-03-26 16:26:18 PDT
Drop unnecessary isReachableFromDOM() function in JSNodeCustom.cpp and inline its implementation in the only caller instead.
Comment 1 Chris Dumez 2022-03-26 16:27:20 PDT
Created attachment 455859 [details]
Patch
Comment 2 Peng Liu 2022-03-26 21:01:35 PDT
Comment on attachment 455859 [details]
Patch

Nice cleanup.
Comment 3 Chris Dumez 2022-03-26 22:04:19 PDT
Comment on attachment 455859 [details]
Patch

Thanks for reviewing!
Comment 4 EWS 2022-03-26 22:04:43 PDT
peng.liu6@icloud.com does not have reviewer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors.json.

Rejecting attachment 455859 [details] from commit queue.
Comment 5 Chris Dumez 2022-03-26 22:05:37 PDT
(In reply to EWS from comment #4)
> peng.liu6@icloud.com does not have reviewer permissions according to
> https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors.
> json.
> 
> Rejecting attachment 455859 [details] from commit queue.

Looks like you will need to update your email in contributors.json Peng.
Comment 6 Chris Dumez 2022-03-28 07:14:17 PDT
Committed r291963 (248928@trunk): <https://commits.webkit.org/248928@trunk>
Comment 7 Radar WebKit Bug Importer 2022-03-28 07:15:21 PDT
<rdar://problem/90920497>