Bug 238382

Summary: [PlayStation] Provide defaults in WebsiteDataStore
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: PlatformAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: stephan.szabo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP Patch
none
WIP Patch
none
WIP Patch
none
WIP Patch none

Don Olmstead
Reported 2022-03-25 09:34:12 PDT
Everything is currently returning empty strings.
Attachments
WIP Patch (4.50 KB, patch)
2022-03-25 09:42 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
WIP Patch (4.51 KB, patch)
2022-03-25 10:00 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
WIP Patch (4.46 KB, patch)
2022-03-25 15:46 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
WIP Patch (5.57 KB, patch)
2022-03-29 10:39 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2022-03-25 09:42:13 PDT
Created attachment 455775 [details] WIP Patch
Stephan Szabo
Comment 2 2022-03-25 09:53:15 PDT
Comment on attachment 455775 [details] WIP Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455775&action=review > Source/WebKit/UIProcess/WebsiteData/playstation/WebsiteDataStorePlayStation.cpp:109 > + return FileSystem::pathByAppendingComponent(FileSystem::userCacheDirectory(), directoryName); Is this correct for cases where we're not in the USE(WPE_BACKEND_PLAYSTATION)? It seems like you'd get whatever the result of appending directoryName to an empty string was, which doesn't seem like it'd retain the previous behavior.
Stephan Szabo
Comment 3 2022-03-25 09:55:55 PDT
Comment on attachment 455775 [details] WIP Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455775&action=review > Source/WebKit/UIProcess/WebsiteData/playstation/WebsiteDataStorePlayStation.cpp:114 > + return FileSystem::pathByAppendingComponent(FileSystem::userDataDirectory(), directoryName); As with cacheDirectoryFileSystemRepresentation, is this going to do what we want in cases userDataDirectory returns an empty string?
Don Olmstead
Comment 4 2022-03-25 10:00:39 PDT
Created attachment 455777 [details] WIP Patch
Don Olmstead
Comment 5 2022-03-25 10:02:38 PDT
This should address the issues mentioned. Going to work on upstreaming libwpe and adding to our WPE backend before marking it for review.
Don Olmstead
Comment 6 2022-03-25 15:46:31 PDT Comment hidden (obsolete)
Don Olmstead
Comment 7 2022-03-29 10:39:02 PDT
Created attachment 456042 [details] WIP Patch
Radar WebKit Bug Importer
Comment 8 2022-04-01 09:35:15 PDT
<rdar://problem/91167092>
Don Olmstead
Comment 9 2022-10-03 09:14:13 PDT
Pull request: https://github.com/WebKit/WebKit/pull/4931
EWS
Comment 10 2022-10-05 12:42:47 PDT
Committed 255192@main (cbc7d03e34bb): <https://commits.webkit.org/255192@main> Reviewed commits have been landed. Closing PR #4931 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.