Bug 238382

Summary: [PlayStation] Provide defaults in WebsiteDataStore
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: PlatformAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: stephan.szabo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP Patch
none
WIP Patch
none
WIP Patch
none
WIP Patch none

Description Don Olmstead 2022-03-25 09:34:12 PDT 
Everything is currently returning empty strings.
Comment 1 Don Olmstead 2022-03-25 09:42:13 PDT 
Created attachment 455775 [details]
WIP Patch
Comment 2 Stephan Szabo 2022-03-25 09:53:15 PDT 
Comment on attachment 455775 [details]
WIP Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455775&action=review

> Source/WebKit/UIProcess/WebsiteData/playstation/WebsiteDataStorePlayStation.cpp:109
> +    return FileSystem::pathByAppendingComponent(FileSystem::userCacheDirectory(), directoryName);

Is this correct for cases where we're not in the USE(WPE_BACKEND_PLAYSTATION)? It seems like you'd get whatever the result of appending directoryName to an empty string was, which doesn't seem like it'd retain the previous behavior.
Comment 3 Stephan Szabo 2022-03-25 09:55:55 PDT 
Comment on attachment 455775 [details]
WIP Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455775&action=review

> Source/WebKit/UIProcess/WebsiteData/playstation/WebsiteDataStorePlayStation.cpp:114
> +    return FileSystem::pathByAppendingComponent(FileSystem::userDataDirectory(), directoryName);

As with cacheDirectoryFileSystemRepresentation, is this going to do what we want in cases userDataDirectory returns an empty string?
Comment 4 Don Olmstead 2022-03-25 10:00:39 PDT 
Created attachment 455777 [details]
WIP Patch
Comment 5 Don Olmstead 2022-03-25 10:02:38 PDT 
This should address the issues mentioned.

Going to work on upstreaming libwpe and adding to our WPE backend before marking it for review.
Comment 6 Don Olmstead 2022-03-25 15:46:31 PDT Comment hidden (obsolete)
Comment 7 Don Olmstead 2022-03-29 10:39:02 PDT 
Created attachment 456042 [details]
WIP Patch
Comment 8 Radar WebKit Bug Importer 2022-04-01 09:35:15 PDT 
<rdar://problem/91167092>
Comment 9 Don Olmstead 2022-10-03 09:14:13 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/4931
Comment 10 EWS 2022-10-05 12:42:47 PDT 
Committed 255192@main (cbc7d03e34bb): <https://commits.webkit.org/255192@main>

Reviewed commits have been landed. Closing PR #4931 and removing active labels.