Bug 238373

Summary: Import clip-path W3C tests
Product: WebKit Reporter: Noam Rosenthal <noam>
Component: CSSAssignee: Noam Rosenthal <noam>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, ews-watchlist, ntim, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 238371    
Attachments:
Description Flags
Patch
none
Patch none

Description Noam Rosenthal 2022-03-25 05:45:47 PDT 
Importing in preparation for CSS shape()
Comment 1 Noam Rosenthal 2022-03-25 05:58:34 PDT 
Created attachment 455749 [details]
Patch
Comment 2 Tim Nguyen (:ntim) 2022-03-25 12:21:28 PDT 
Comment on attachment 455749 [details]
Patch

LGTM, but please address ios-wk2 failures before landing.
Comment 3 Noam Rosenthal 2022-03-25 13:16:38 PDT 
(In reply to Tim Nguyen (:ntim) from comment #2)
> Comment on attachment 455749 [details]
> Patch
> 
> LGTM, but please address ios-wk2 failures before landing.

Thanks, will do
Probably a matter of adding fuzz meta, will look into it.
Comment 4 Noam Rosenthal 2022-03-26 01:44:38 PDT 
Created attachment 455837 [details]
Patch
Comment 5 EWS 2022-03-26 23:34:26 PDT 
Committed r291949 (248916@main): <https://commits.webkit.org/248916@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455837 [details].
Comment 6 Radar WebKit Bug Importer 2022-03-26 23:35:17 PDT 
<rdar://problem/90887333>
Comment 7 Tim Nguyen (:ntim) 2022-03-27 00:08:55 PDT 
(In reply to Noam Rosenthal from comment #3)
> (In reply to Tim Nguyen (:ntim) from comment #2)
> > Comment on attachment 455749 [details]
> > Patch
> > 
> > LGTM, but please address ios-wk2 failures before landing.
> 
> Thanks, will do
> Probably a matter of adding fuzz meta, will look into it.

Can you export those changes to the WPT repo? Otherwise, they'll get lost at the next import.
Comment 8 Noam Rosenthal 2022-03-27 00:10:09 PDT 
(In reply to Tim Nguyen (:ntim) from comment #7)
> (In reply to Noam Rosenthal from comment #3)
> > (In reply to Tim Nguyen (:ntim) from comment #2)
> > > Comment on attachment 455749 [details]
> > > Patch
> > > 
> > > LGTM, but please address ios-wk2 failures before landing.
> > 
> > Thanks, will do
> > Probably a matter of adding fuzz meta, will look into it.
> 
> Can you export those changes to the WPT repo? Otherwise, they'll get lost at
> the next import.

Will do.
Btw css-masking had a lot of those that weren't previously exported, I'll export all of them.
Comment 9 Noam Rosenthal 2022-03-27 05:19:32 PDT 
(In reply to Noam Rosenthal from comment #8)
> (In reply to Tim Nguyen (:ntim) from comment #7)
> > (In reply to Noam Rosenthal from comment #3)
> > > (In reply to Tim Nguyen (:ntim) from comment #2)
> > > > Comment on attachment 455749 [details]
> > > > Patch
> > > > 
> > > > LGTM, but please address ios-wk2 failures before landing.
> > > 
> > > Thanks, will do
> > > Probably a matter of adding fuzz meta, will look into it.
> > 
> > Can you export those changes to the WPT repo? Otherwise, they'll get lost at
> > the next import.
> 
> Will do.

Done
https://github.com/web-platform-tests/wpt/pull/33378
Had to do this manually because the wpt-export script was barfing, I think it needs some love.
Comment 10 Tim Nguyen (:ntim) 2022-03-28 02:09:51 PDT 
(In reply to Noam Rosenthal from comment #9)
> (In reply to Noam Rosenthal from comment #8)
> > (In reply to Tim Nguyen (:ntim) from comment #7)
> > > (In reply to Noam Rosenthal from comment #3)
> > > > (In reply to Tim Nguyen (:ntim) from comment #2)
> > > > > Comment on attachment 455749 [details]
> > > > > Patch
> > > > > 
> > > > > LGTM, but please address ios-wk2 failures before landing.
> > > > 
> > > > Thanks, will do
> > > > Probably a matter of adding fuzz meta, will look into it.
> > > 
> > > Can you export those changes to the WPT repo? Otherwise, they'll get lost at
> > > the next import.
> > 
> > Will do.
> 
> Done
> https://github.com/web-platform-tests/wpt/pull/33378
> Had to do this manually because the wpt-export script was barfing, I think
> it needs some love.

Thanks! The files you edited in the PR unfortunately don't quite match the ones in the commit, see: https://bugs.webkit.org/attachment.cgi?oldid=455749&action=interdiff&newid=455837&headers=1 which I think is helpful.
Comment 11 Noam Rosenthal 2022-03-28 02:16:11 PDT 
(In reply to Tim Nguyen (:ntim) from comment #10)
> (In reply to Noam Rosenthal from comment #9)
> > (In reply to Noam Rosenthal from comment #8)
> > > (In reply to Tim Nguyen (:ntim) from comment #7)
> > > > (In reply to Noam Rosenthal from comment #3)
> > > > > (In reply to Tim Nguyen (:ntim) from comment #2)
> > > > > > Comment on attachment 455749 [details]
> > > > > > Patch
> > > > > > 
> > > > > > LGTM, but please address ios-wk2 failures before landing.
> > > > > 
> > > > > Thanks, will do
> > > > > Probably a matter of adding fuzz meta, will look into it.
> > > > 
> > > > Can you export those changes to the WPT repo? Otherwise, they'll get lost at
> > > > the next import.
> > > 
> > > Will do.
> > 
> > Done
> > https://github.com/web-platform-tests/wpt/pull/33378
> > Had to do this manually because the wpt-export script was barfing, I think
> > it needs some love.
> 
> Thanks! The files you edited in the PR unfortunately don't quite match the
> ones in the commit, see:
> https://bugs.webkit.org/attachment.
> cgi?oldid=455749&action=interdiff&newid=455837&headers=1 which I think is
> helpful.

Thanks, I was trying to use the export tool but it's not being helpful. A bit frustrated by this TBH but will try.