| Summary: | [CSS Shapes] Add support for shape() | ||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Noam Rosenthal <noam> | ||||||||||||||||||||||||||||
| Component: | CSS | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||||||||||||||||||||||
| Status: | NEW --- | ||||||||||||||||||||||||||||||
| Severity: | Normal | CC: | annulen, changseok, clopez, darin, esprehn+autocc, ews-watchlist, glenn, graouts, gyuyoung.kim, koivisto, kondapallykalyan, macpherson, menard, pdr, ryuan.choi, sam, sebastianzartner, sergio, simon.fraser, webkit-bug-importer, youennf | ||||||||||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||||||
| Bug Depends on: | 238373, 277183, 277211 | ||||||||||||||||||||||||||||||
| Bug Blocks: | |||||||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||||||
|
Description
Noam Rosenthal
2022-03-25 05:39:44 PDT
Created attachment 457864 [details]
Patch
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess Corresponding Chromium bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1308431 Corresponding Mozilla bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1758784 Created attachment 457866 [details]
Patch
Created attachment 457867 [details]
Patch
Created attachment 457870 [details]
Patch
Created attachment 457874 [details]
Patch
Created attachment 457877 [details]
Patch
Created attachment 457881 [details]
Patch
Created attachment 457885 [details]
Patch
Created attachment 457889 [details]
Patch
Created attachment 457891 [details]
Patch
Created attachment 457901 [details]
Patch
Created attachment 457914 [details]
Patch
Hi Noam. Do you know whether there are existing animation tests for shape()? I don't see any new PASS results in the diff for tests that would improve. Do we need to import more? If so, I think it would be nice to import them first as failures, so this patch shows the progress. If not, then it would be GREAT for this patch to add animation testing coverage and upstream it to WPT. (In reply to Antoine Quint from comment #16) > Hi Noam. Do you know whether there are existing animation tests for shape()? > I don't see any new PASS results in the diff for tests that would improve. > Do we need to import more? If so, I think it would be nice to import them > first as failures, so this patch shows the progress. If not, then it would > be GREAT for this patch to add animation testing coverage and upstream it to > WPT. Yes of course, those tests are already upstreamed to WPT and imported to webkit, and this patch unskips them. imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-shape-interpolation-001.html imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-shape-interpolation-002.html Created attachment 457962 [details]
Patch
Review anyone? (In reply to Simon Fraser (smfr) from comment #20) > https://github.com/w3c/csswg-drafts/issues/5841 I believe these were addressed 2 years ago already, Tab added a lot regarding animation support for example. Apologies, I see that only some of the comments (the animation related ones) were addressed and I missed the other ones. Will get back to the issue. Noam, do you mind if I take this over? (In reply to Simon Fraser (smfr) from comment #23) > Noam, do you mind if I take this over? Please do, that would make me very happy! I suspect that my patch from 2 years ago is still mostly valid, and https://github.com/w3c/csswg-drafts/issues/5841 is still up and I think not far from a resolution. Hopefully if WebKit takes this on I can make the case for prioritizing this work in chrome as well. |