Bug 238359

Summary: Mismatched forward declaration of GraphicsContextState
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: Tools / TestsAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
darin: review+
Patch none

Description Don Olmstead 2022-03-24 17:35:29 PDT
Its a class not a struct
Comment 1 Don Olmstead 2022-03-24 17:37:32 PDT
Created attachment 455711 [details]
Patch
Comment 2 Darin Adler 2022-03-24 17:48:47 PDT
Comment on attachment 455711 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455711&action=review

> Source/WebCore/platform/graphics/cairo/CairoOperations.h:51
> +class GraphicsContextState;

Should sort in with other class forward declarations above and merge into that paragraph.
Comment 3 Don Olmstead 2022-03-24 17:51:08 PDT
Created attachment 455715 [details]
Patch
Comment 4 Don Olmstead 2022-03-24 17:51:27 PDT
(In reply to Darin Adler from comment #2)
> Comment on attachment 455711 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=455711&action=review
> 
> > Source/WebCore/platform/graphics/cairo/CairoOperations.h:51
> > +class GraphicsContextState;
> 
> Should sort in with other class forward declarations above and merge into
> that paragraph.

Good catch! Patch updated
Comment 5 EWS 2022-03-25 00:44:49 PDT
Committed r291850 (248862@main): <https://commits.webkit.org/248862@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455715 [details].
Comment 6 Radar WebKit Bug Importer 2022-03-25 00:45:18 PDT
<rdar://problem/90823281>