Bug 238345

Summary:

[css-cascade] makeprop.pl should sort deferred properties at the end

Product:

WebKit

Reporter:

Oriol Brufau <obrufau>

Component:

CSS

Assignee:

Oriol Brufau <obrufau>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, joepeck, koivisto, macpherson, menard, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=238888

Bug Depends on:

238350

Bug Blocks:

238260

Attachments:

Description	Flags
Patch	none
Patch for EWS	none
Patch	none
Patch for EWS	none

Oriol Brufau

Reported 2022-03-24 13:06:36 PDT

Currently, the CSSPropertyID enum is sorted like this: 1. Special meaning: CSSPropertyInvalid and CSSPropertyCustom 2. High priority properties: firstCSSProperty..lastHighPriorityProperty 3. Low priority properties: (lastHighPriorityProperty+1)..lastCSSProperty However, among low priority ones, there are some that are not cascaded with the others, they are deferred and applied in parse order. These should be sorted into their own category at the end: 1. Special meaning: CSSPropertyInvalid and CSSPropertyCustom 2. High priority properties: firstCSSProperty..lastHighPriorityProperty 3. Low priority properties: (lastHighPriorityProperty+1)..lastLowPriorityProperty 4. Deferred properties: (lastLowPriorityProperty+1)..lastCSSProperty This would help bug 238260.

Attachments
Patch (14.98 KB, patch) 2022-03-25 10:52 PDT, Oriol Brufau	no flags	Details Formatted Diff Diff
Patch for EWS (48.15 KB, patch) 2022-03-25 10:53 PDT, Oriol Brufau	no flags	Details Formatted Diff Diff
Patch (14.99 KB, patch) 2022-03-25 11:49 PDT, Oriol Brufau	no flags	Details Formatted Diff Diff
Patch for EWS (48.16 KB, patch) 2022-03-25 11:50 PDT, Oriol Brufau	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2022-03-24 13:55:44 PDT

Since this is a generated file, I suggest we generate first/last constants for each section. first/lastCSSProperty first/lastHighPriorityCSSProperty first/lastLowPriorityCSSProperty first/lastDeferredCSSProperty That way, most code that wants to make checks can be written without depending on the ordering at all; the few places that do depend on the ordering can be written in the clearest fashion possible. Somewhere we could even put functions so we don't have to use these constants directly so often: bool isHighPriority(CSSPropertyID); bool isLowPriority(CSSPropertyID); bool isDeferred(CSSPropertyID); Or whatever predicates we need. I think it helps when code can write such things so they read cleanly even if they are just expanding to < and > checks.

Oriol Brufau

Comment 2 2022-03-24 14:22:34 PDT

Yes, actually StyleBuilder.cpp already has static const CSSPropertyID firstLowPriorityProperty = static_cast<CSSPropertyID>(lastHighPriorityProperty + 1);

Radar WebKit Bug Importer

Comment 3 2022-03-24 16:06:24 PDT

<rdar://problem/90799486>

Oriol Brufau

Comment 4 2022-03-25 10:52:16 PDT

Created attachment 455784 [details] Patch

Oriol Brufau

Comment 5 2022-03-25 10:53:03 PDT

Created attachment 455785 [details] Patch for EWS

Oriol Brufau

Comment 6 2022-03-25 11:49:18 PDT

Created attachment 455789 [details] Patch