Bug 238344

Summary: FileSystem::pathByAppendingComponent() should take in StringViews instead of Strings
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web Template FrameworkAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, beidson, benjamin, cgarcia, cmarcelo, darin, ews-watchlist, galpeter, ggaren, hi, joepeck, jsbell, keith_miller, mark.lam, msaboff, pangle, saam, tzagallo, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch none

Description Chris Dumez 2022-03-24 12:52:19 PDT 
FileSystem::pathByAppendingComponent() should take in StringViews instead of Strings, to avoid unnecessary String constructor in many instances.
Comment 1 Chris Dumez 2022-03-24 13:31:26 PDT 
Created attachment 455671 [details]
Patch
Comment 2 Chris Dumez 2022-03-24 13:37:16 PDT 
Created attachment 455673 [details]
Patch
Comment 3 Chris Dumez 2022-03-24 14:04:20 PDT 
Created attachment 455678 [details]
Patch
Comment 4 Geoffrey Garen 2022-03-24 16:08:46 PDT 
Comment on attachment 455678 [details]
Patch

r=me
Comment 5 EWS 2022-03-24 17:17:17 PDT 
Tools/Scripts/svn-apply failed to apply attachment 455678 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 6 Chris Dumez 2022-03-24 17:48:41 PDT 
Created attachment 455714 [details]
Patch
Comment 7 EWS 2022-03-24 19:06:21 PDT 
Committed r291842 (248856@main): <https://commits.webkit.org/248856@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455714 [details].
Comment 8 Radar WebKit Bug Importer 2022-03-24 19:07:17 PDT 
<rdar://problem/90811502>
Comment 9 Wenson Hsieh 2022-03-25 08:55:50 PDT 
Committed r291854 (248866@trunk): <https://commits.webkit.org/248866@trunk>