Bug 238336

Summary: Start preparing WebCore for making the String(const char*) constructor explicit
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, alecflett, andresg_22, apinheiro, beidson, benjamin, calvaris, cfleizach, changseok, cmarcelo, darin, dino, dmazzoni, eric.carlson, esprehn+autocc, ews-watchlist, fmalita, ggaren, glenn, gyuyoung.kim, hi, hta, japhet, jcraig, jdiggs, jer.noble, jfernandez, joepeck, jsbell, keith_miller, kondapallykalyan, macpherson, mark.lam, menard, mifenton, msaboff, pangle, pascoe, pdr, philipj, rego, saam, sabouhallawa, samuel_white, schenney, sergio, svillar, tommyw, toyoshim, tzagallo, webkit-bug-importer, yutak
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=238264
https://bugs.webkit.org/show_bug.cgi?id=238408
Bug Depends on:    
Bug Blocks: 238693    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Description Chris Dumez 2022-03-24 10:51:22 PDT 
Start preparing WebCore for making the String(const char*) constructor explicit.
Making this constructor explicit helps catch at compile time cases where the ""_s prefix is missing on String literals.
Comment 1 Chris Dumez 2022-03-24 13:16:46 PDT 
Created attachment 455670 [details]
Patch
Comment 2 Chris Dumez 2022-03-24 13:32:15 PDT 
Created attachment 455672 [details]
Patch
Comment 3 Chris Dumez 2022-03-24 14:51:44 PDT 
Created attachment 455688 [details]
Patch
Comment 4 Chris Dumez 2022-03-24 14:56:14 PDT 
Created attachment 455691 [details]
Patch
Comment 5 Chris Dumez 2022-03-24 16:14:34 PDT 
Created attachment 455700 [details]
Patch
Comment 6 Chris Dumez 2022-03-24 17:44:36 PDT 
Created attachment 455713 [details]
Patch
Comment 7 Chris Dumez 2022-03-24 19:48:58 PDT 
Created attachment 455719 [details]
Patch
Comment 8 Chris Dumez 2022-03-24 20:59:47 PDT 
Created attachment 455722 [details]
Patch
Comment 9 Chris Dumez 2022-03-24 21:58:44 PDT 
Created attachment 455723 [details]
Patch
Comment 10 Chris Dumez 2022-03-24 22:37:54 PDT 
Created attachment 455724 [details]
Patch
Comment 11 Chris Dumez 2022-03-25 07:23:10 PDT 
Created attachment 455757 [details]
Patch
Comment 12 Geoffrey Garen 2022-03-25 10:01:24 PDT 
Comment on attachment 455757 [details]
Patch

r=me
Comment 13 Chris Dumez 2022-03-25 10:13:20 PDT 
Comment on attachment 455757 [details]
Patch

Clearing flags on attachment: 455757

Committed r291863 (248870@trunk): <https://commits.webkit.org/248870@trunk>
Comment 14 Chris Dumez 2022-03-25 10:13:28 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 15 Radar WebKit Bug Importer 2022-03-25 10:14:21 PDT 
<rdar://problem/90843719>