Bug 238334

Summary: Do not use std::numeric_limits<float>::min() as the initial value to collect max values for glyph overflow
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, dbarton, ews-watchlist, fred.wang, mmaxfield, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description zalan 2022-03-24 10:23:56 PDT 
It has the side effect of a "never empty glyph vertical overflow"  ( ceilf(std::max(0, std::min)) -> 1px )
Comment 1 zalan 2022-03-24 10:34:38 PDT 
Created attachment 455650 [details]
Patch
Comment 2 Simon Fraser (smfr) 2022-03-24 11:33:18 PDT 
Comment on attachment 455650 [details]
Patch

Is there a behavior change here? No tests change?
Comment 3 zalan 2022-03-24 12:17:14 PDT 
(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 455650 [details]
> Patch
> 
> Is there a behavior change here? No tests change?
Yes, I am using EWS to collect the new baseline.
Comment 4 zalan 2022-03-25 06:12:00 PDT 
Created attachment 455752 [details]
Patch
Comment 5 Radar WebKit Bug Importer 2022-03-31 10:24:15 PDT 
<rdar://problem/91111725>
Comment 6 zalan 2022-04-07 15:03:36 PDT 
Created attachment 456973 [details]
Patch
Comment 7 zalan 2022-04-08 05:42:46 PDT 
Created attachment 457057 [details]
Patch
Comment 8 EWS 2022-04-08 08:01:56 PDT 
Committed r292606 (249438@main): <https://commits.webkit.org/249438@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457057 [details].