Bug 238306

Summary:

[LFC][IFC] Remove slow codepath matching arithmetics in FontCascade::widthForSimpleText

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, ews-watchlist, koivisto, mmaxfield, Morningstar, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=238581

Attachments:

Description	Flags
Patch	none

Description zalan 2022-03-23 20:34:07 PDT

ssia

Comment 1 zalan 2022-03-23 20:37:37 PDT

Created attachment 455600 [details]
Patch

Comment 2 Antti Koivisto 2022-03-24 06:34:20 PDT

Comment on attachment 455600 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455600&action=review

> Source/WebCore/platform/graphics/FontCascade.cpp:323
> -    float afterWidth = 0;
> +    auto width = 0.f;

good job!

Comment 3 EWS 2022-03-24 12:40:25 PDT

Committed r291811 (248838@main): <https://commits.webkit.org/248838@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455600 [details].

Comment 4 Radar WebKit Bug Importer 2022-03-24 12:41:17 PDT

<rdar://problem/90784805>