Bug 238234

Summary: REGRESSION (248499@main): [iOS] ASSERTION FAILED: Completion handler should always be called under WebKit::NetworkProcess::prepareToSuspend()
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, sihui_liu, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari 13   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=237943
Attachments:
Description Flags
crash log
none
Patch none

Description Ryan Haddad 2022-03-22 16:10:03 PDT 
Created attachment 455447 [details]
crash log

Layout tests are exiting early on iOS debug bots with crashes, all appear to be the following assert:

ASSERTION FAILED: Completion handler should always be called
!m_function
/Volumes/Data/worker/ios-simulator-15-debug/build/WebKitBuild/Debug-iphonesimulator/usr/local/include/wtf/CompletionHandler.h(59) : WTF::CompletionHandler<void ()>::~CompletionHandler()
1   0x119499169 WTFCrash
2   0x127b10da7 WTF::CompletionHandler<void ()>::~CompletionHandler()
3   0x127b0f275 WTF::CompletionHandler<void ()>::~CompletionHandler()
4   0x1289e0ca9 auto WebKit::NetworkProcess::prepareToSuspend(bool, WTF::CompletionHandler<void ()>&&)::$_63::operator()<WebKit::NetworkSession>(WebKit::NetworkSession&) const
5   0x1289e0b31 WTF::Detail::CallableWrapper<WebKit::NetworkProcess::prepareToSuspend(bool, WTF::CompletionHandler<void ()>&&)::$_63, void, WebKit::NetworkSession&>::call(WebKit::NetworkSession&)
6   0x12895e307 WTF::Function<void (WebKit::NetworkSession&)>::operator()(WebKit::NetworkSession&) const
7   0x12895be59 WebKit::NetworkProcess::forEachNetworkSession(WTF::Function<void (WebKit::NetworkSession&)> const&)
8   0x1289685ad WebKit::NetworkProcess::prepareToSuspend(bool, WTF::CompletionHandler<void ()>&&)
9   0x127de3852 void IPC::callMemberFunctionImpl<WebKit::NetworkProcess, void (WebKit::NetworkProcess::*)(bool, WTF::CompletionHandler<void ()>&&), void (), std::__1::tuple<bool>, 0ul>(WebKit::NetworkProcess*, void (WebKit::NetworkProcess::*)(bool, WTF::CompletionHandler<void ()>&&), WTF::CompletionHandler<void ()>&&, std::__1::tuple<bool>&&, std::__1::integer_sequence<unsigned long, 0ul>)
10  0x127de2de2 void IPC::callMemberFunction<WebKit::NetworkProcess, void (WebKit::NetworkProcess::*)(bool, WTF::CompletionHandler<void ()>&&), void (), std::__1::tuple<bool>, std::__1::integer_sequence<unsigned long, 0ul> >(std::__1::tuple<bool>&&, WTF::CompletionHandler<void ()>&&, WebKit::NetworkProcess*, void (WebKit::NetworkProcess::*)(bool, WTF::CompletionHandler<void ()>&&))
11  0x127d828d9 void IPC::handleMessageAsync<Messages::NetworkProcess::PrepareToSuspend, WebKit::NetworkProcess, void (WebKit::NetworkProcess::*)(bool, WTF::CompletionHandler<void ()>&&)>(IPC::Connection&, IPC::Decoder&, WebKit::NetworkProcess*, void (WebKit::NetworkProcess::*)(bool, WTF::CompletionHandler<void ()>&&))
12  0x127d7d8a5 WebKit::NetworkProcess::didReceiveNetworkProcessMessage(IPC::Connection&, IPC::Decoder&)
13  0x12895baae WebKit::NetworkProcess::didReceiveMessage(IPC::Connection&, IPC::Decoder&)


https://build.webkit.org/results/Apple-iOS-15-Simulator-Debug-WK2-Tests/r291624%20(2030)/results.html
Comment 1 Ryan Haddad 2022-03-22 16:10:59 PDT 
This started between 248494@main and 248504@main, so https://commits.webkit.org/248499@main seems to be the most likely candidate for a regression point.
Comment 2 Radar WebKit Bug Importer 2022-03-22 16:11:57 PDT 
<rdar://problem/90665237>
Comment 3 Sihui Liu 2022-03-22 16:27:41 PDT 
Created attachment 455453 [details]
Patch
Comment 4 EWS 2022-03-22 18:40:31 PDT 
Committed r291732 (248764@main): <https://commits.webkit.org/248764@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455453 [details].