| Summary: | calc(): Handle finite value with infinite step in round() | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Nikos Mouchtaris <nmouchtaris> | ||||||
| Component: | New Bugs | Assignee: | Nikos Mouchtaris <nmouchtaris> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, simon.fraser, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Nikos Mouchtaris
2022-03-22 15:56:02 PDT
Created attachment 455445 [details]
Patch
Comment on attachment 455445 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455445&action=review > Source/WebCore/css/calc/CSSCalcPrimitiveValueNode.cpp:89 > + m_value = CSSPrimitiveValue::create(signbit(m_value->doubleValue()) ? -std::numeric_limits<double>::infinity() : std::numeric_limits<double>::infinity(), m_value->primitiveType()); can this use copysign()? Created attachment 455684 [details]
Patch
(In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 455445 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=455445&action=review > > > Source/WebCore/css/calc/CSSCalcPrimitiveValueNode.cpp:89 > > + m_value = CSSPrimitiveValue::create(signbit(m_value->doubleValue()) ? -std::numeric_limits<double>::infinity() : std::numeric_limits<double>::infinity(), m_value->primitiveType()); > > can this use copysign()? Fixed. Committed r291841 (248855@main): <https://commits.webkit.org/248855@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455684 [details]. |