Bug 238221

Summary: Add URL::stringWithoutFragmentIdentifier() overload which returns a String instead of a StringView
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web Template FrameworkAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, cmarcelo, darin, ews-watchlist, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=236069
Attachments:
Description Flags
Patch none

Description Chris Dumez 2022-03-22 13:05:01 PDT 
Add URL::stringWithoutFragmentIdentifier() overload which returns a String instead of a StringView.
Comment 1 Chris Dumez 2022-03-22 13:06:14 PDT 
Created attachment 455419 [details]
Patch
Comment 2 Geoffrey Garen 2022-03-22 16:37:10 PDT 
Comment on attachment 455419 [details]
Patch

r=me
Comment 3 EWS 2022-03-22 17:59:55 PDT 
Committed r291730 (248762@main): <https://commits.webkit.org/248762@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455419 [details].
Comment 4 Radar WebKit Bug Importer 2022-03-22 18:00:21 PDT 
<rdar://problem/90670425>
Comment 5 Alex Christensen 2022-03-22 20:01:48 PDT 
What motivated this change?
Comment 6 Chris Dumez 2022-03-22 20:02:54 PDT 
(In reply to Alex Christensen from comment #5)
> What motivated this change?

Review feedback from Darin here: https://bugs.webkit.org/show_bug.cgi?id=236069#c11