Bug 238218

Summary:

REGRESSION(r291546): 7% regression in Speedometer2/jQuery-TodoMVC

Product:

WebKit

Reporter:

WebKit Commit Bot <commit-queue>

Component:

New Bugs

Assignee:

WebKit Commit Bot <commit-queue>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, obrufau, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

236199

Attachments:

Description	Flags
REVERT of r291546	none
Speedometer perf graph	none

Description WebKit Commit Bot 2022-03-22 12:16:20 PDT

https://commits.webkit.org/r291546 introduced a regression:
7% regression in Speedometer2/jQuery-TodoMVC

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.

Comment 1 WebKit Commit Bot 2022-03-22 12:16:32 PDT

Created attachment 455409 [details]
REVERT of r291546

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the revert will be successful.  This process takes approximately 15 minutes.

If you would like to land the revert faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

Comment 2 Oriol Brufau 2022-03-22 12:46:35 PDT

Created attachment 455415 [details]
Speedometer perf graph

I don't see the regression in the graph. https://perf.webkit.org/v3/#/charts?since=1645697402120&zoom=(1647663655286.3-1647948619513.3)&paneList=((22-946-47978999-null-(5-2.5-500))-(16-946-47980467-null-(5-2.5-500)))&repository=1

Comment 3 Yusuke Suzuki 2022-03-22 12:50:18 PDT

I shared the internal data with Antoine, showing all iOS bots are regressed.
Please discuss with Antoine to make it perf-neutral.

Comment 4 EWS 2022-03-22 12:56:01 PDT

Committed r291690 (248732@main): <https://commits.webkit.org/248732@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455409 [details].

Comment 5 Radar WebKit Bug Importer 2022-03-22 12:57:17 PDT

<rdar://problem/90654099>