Bug 238171

Summary: Roll ANGLE to 2022-03-22 (e7f29440f02514126f30350dcd7132b68f7954d7)
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: ANGLEAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bfulgham, dino, ews-watchlist, geofflang, gman, gyuyoung.kim, jonahr, kbr, kkinnunen, kondapallykalyan, kpiddington, ryuan.choi, sergio, simontaylor1, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 235746    
Bug Blocks: 236713, 238118, 238135, 238196    
Attachments:
Description Flags
Patch
none
Patch ews-feeder: commit-queue-

Kenneth Russell
Reported 2022-03-21 17:11:11 PDT
To pick up the latest bug fixes to ANGLE's Metal backend, let's roll ANGLE to top-of-tree as of 2022-03-21. Note that this depends on just-filed anglebug.com/7115 and https://chromium-review.googlesource.com/3537512 . (It was possible to patch the update-angle script to do this, but it's better to just pick up the proper fix from upstream.)
Attachments
Patch (2.05 MB, patch)
2022-03-22 11:36 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
Patch (2.05 MB, patch)
2022-03-22 15:45 PDT, Kenneth Russell 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-03-22 09:06:30 PDT
<rdar://problem/90639134>
Kenneth Russell
Comment 2 2022-03-22 11:30:25 PDT
Rolling to 2022-03-22 instead: e7f29440f02514126f30350dcd7132b68f7954d7 https://chromium.googlesource.com/angle/angle/+/e7f29440f02514126f30350dcd7132b68f7954d7
Kenneth Russell
Comment 3 2022-03-22 11:36:47 PDT
Created attachment 455404 [details] Patch
EWS Watchlist
Comment 4 2022-03-22 11:38:25 PDT
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Kenneth Russell
Comment 5 2022-03-22 15:45:29 PDT
Created attachment 455441 [details] Patch
Kenneth Russell
Comment 6 2022-03-22 15:45:49 PDT
Fixed CMake build in the latest patch.
Kenneth Russell
Comment 7 2022-03-22 16:07:32 PDT
Added Bug 238196 to the list that this blocks. Have confirmed on Bug 238118 that this roll definitely fixes more multisampled rendering bugs compared to WebKit ToT.
Kimmo Kinnunen
Comment 8 2022-03-23 03:33:12 PDT
Comment on attachment 455441 [details] Patch Great work, thanks!
Kenneth Russell
Comment 9 2022-03-23 11:04:34 PDT
The layout test failures are definitely unrelated to this ANGLE roll. CQ'ing.
EWS
Comment 10 2022-03-23 11:55:12 PDT
Committed r291757 (248788@main): <https://commits.webkit.org/248788@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455441 [details].
Kenneth Russell
Comment 11 2022-03-23 13:22:11 PDT
Note: the EWS found the following failure with this patch: --- EWS has detected layout test failure on iOS-15-Simulator-WK2-Tests-EWS while testing Patch 455441 for Bug 238171. Full details are available at: https://ews-build.webkit.org/#/builders/68/builds/11320 Layout test failure: - editing/spelling/spellcheck-async-remove-frame.html (test history) Test history: https://results.webkit.org/?suite=layout-tests&test=editing/spelling/spellcheck-async-remove-frame.html --- I'm positive that this flake is unrelated to this patch - please don't revert this ANGLE roll in response to it. Thanks.
Simon Taylor
Comment 12 2022-04-02 05:35:49 PDT
I've done a TOT build of WebKit and tested via the run-safari script, and still see the failures on some of the three examples with antialiasing, such as: https://threejs.org/examples/#webgl_materials_cubemap_dynamic where the background isn't shown. Tools/Scripts/build-webkit --release Tools/Scripts/run-safari Not sure how to verify that my built version is indeed being used, but I have checked that the files in my working copy do have the changes from this roll.
Simon Taylor
Comment 13 2022-04-02 05:37:11 PDT
(In reply to Simon Taylor from comment #12) > I've done a TOT build of WebKit and tested via the run-safari script, and > still see the failures on some of the three examples with antialiasing, such > as: > https://threejs.org/examples/#webgl_materials_cubemap_dynamic where the > background isn't shown. I should have specified this is on my M1 Pro MBP on latest macOS 12.3.
Kenneth Russell
Comment 14 2022-04-12 12:17:59 PDT
Simon: there's a bug in the build products and run-safari script, and run-safari isn't picking up your locally built WebKit. Please use run-minibrowser.
Brent Fulgham
Comment 15 2022-05-26 15:01:57 PDT
This fix shipped with Safari 15.5 (all platforms).
Note You need to log in before you can comment on or make changes to this bug.