| Summary: | It should be possible to copy text out of “AutoFilledAndViewable” password fields | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ricky Mondello <rmondello> | ||||||||||
| Component: | Forms | Assignee: | Ricky Mondello <rmondello> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | cdumez, ews-watchlist, ggaren, mifenton, webkit-bug-importer, wenson_hsieh | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | Safari Technology Preview | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Ricky Mondello
2022-03-21 15:59:58 PDT
Created attachment 455290 [details]
Patch
Created attachment 455292 [details]
Patch
Created attachment 455294 [details]
Patch
Comment on attachment 455294 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455294&action=review r=me > Source/WebCore/editing/VisibleSelection.cpp:686 > +bool VisibleSelection::isInAutoFilledAndViewablePasswordField() const I think this helper function's usage would be more straight-forward if the function only computed "isInAutoFilledAndViewableField" and not also "isInPasswordField" -- since the caller already checks whether the selection is in a password field. Created attachment 455299 [details]
Patch
Comment on attachment 455299 [details]
Patch
r=me
Committed r291623 (248716@main): <https://commits.webkit.org/248716@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455299 [details]. |